305761 - setPropertyPriority does not reset importance

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Tested on Firefox 1.0.6 : the test attached should reset the priority of the CSS
rule but it does not...

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: test case

Comment 2

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Attachment: tentative patch

Comment 3

[Martijn Wargers (dead)]

Attachment: Testcase2

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Doesn't this patch break:

p { 
  color: green ! important;
  color: red;
}

<p>This should be green.</p>

?

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 193704 [details] [diff] [review]
tentative patch

(In reply to comment #4)
> Doesn't this patch break:
> 
> p { 
>   color: green ! important;
>   color: red;
> }
> 
> <p>This should be green.</p>
> 
> ?

DANG. Good catch David:-/

Comment 6

[Boris Zbarsky [:bzbarsky]]

So it's not clear to me how this stuff should behave... in particular, how should access via CSS2Properties interact with preexisting !important values?  How should setPropertyValue() really interact with them?

I'm tempted to just manually call RemoveProperty in all cases when we might need to replace a !important property with a non-!important one, but I _really_ don't want to slow down the CSS2Properties stuff, so I'd like to sort out the behavior we'll need there first.

Comment 7

[Gregory Pappas [:gregp]]

I can repro this in a build from 2008-9-22, it was eventually fixed by...something. I got a range but it looks super off because I had to skip a bunch of crashy/broken builds.