Closed
Bug 305767
Opened 19 years ago
Closed 19 years ago
Allow a different marker character for preprocessing CSS files
Categories
(Firefox Build System :: General, defect, P2)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.8.1
People
(Reporter: benjamin, Assigned: benjamin)
References
Details
(Keywords: fixed1.8.1)
Attachments
(3 files)
25.91 KB,
patch
|
ian
:
review+
mconnor
:
superreview+
|
Details | Diff | Splinter Review |
55.22 KB,
patch
|
benjamin
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
3.37 KB,
text/html
|
Details |
Since CSS files tend to contain '#' at the beginning of lines (for ID selectors), the preprocessor doesn't work well on them. The patch will allow an arbitrary character to be the preprocessor-marker-character, and will alter make-jars so that '%' is the preprocessor character for CSS files.
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #193706 -
Flags: superreview?(mconnor)
Attachment #193706 -
Flags: review?(ian)
Comment 2•19 years ago
|
||
Comment on attachment 193706 [details] [diff] [review] Preprocess CSS with '%' r=hixie, on the preprocessor parts at least (the other parts seemed fine too).
Attachment #193706 -
Flags: review?(ian) → review+
Assignee | ||
Updated•19 years ago
|
Priority: -- → P2
Updated•19 years ago
|
Attachment #193706 -
Flags: superreview?(mconnor) → superreview+
Assignee | ||
Comment 3•19 years ago
|
||
fixed on trunk
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Comment 4•19 years ago
|
||
Winstripe chrome://browser/skin/preferences/preferences.css Is this no problem?
Comment 5•19 years ago
|
||
Its not a problem because its wrapped in a comment, but if we want it preprocessed we need to s/#/%/ as appropriate.
Comment 6•18 years ago
|
||
Attachment #210808 -
Flags: branch-1.8.1?(benjamin)
Comment 7•18 years ago
|
||
I used this to verify that the patch was correct.
Comment 8•18 years ago
|
||
find -name "*.css" | xargs egrep "^#( |if|endif)" also doesn't find any files that need preprocessing (just commented out license headers in files that aren't preprocessed anyways).
Assignee | ||
Updated•18 years ago
|
Attachment #210808 -
Flags: branch-1.8.1?(benjamin) → branch-1.8.1+
Comment 9•18 years ago
|
||
Comment on attachment 210808 [details] [diff] [review] 1.8 branch patch extensions/help/resources/content/platformClasses.css; new revision: 1.2.28.1; themes/classic/global/win/menu.css; new revision: 1.56.8.2; toolkit/components/help/content/platformClasses.css; new revision: 1.2.20.1; layout/style/Makefile.in; new revision: 1.7.12.1; layout/style/forms.css; new revision: 3.104.4.4; config/make-jars.pl; new revision: 3.84.2.3; config/preprocessor.pl; new revision: 3.30.4.1; config/preprocessor.txt; new revision: 1.3.20.1; toolkit/content/xul.css; new revision: 1.61.2.6; toolkit/themes/qute/communicator/pref/pref.css; new revision: 1.2.26.3; toolkit/themes/qute/help/help.css; new revision: 1.5.2.1; toolkit/themes/qute/help/sidebar.css; new revision: 1.3.10.2; toolkit/themes/winstripe/help/help.css; new revision: 1.12.2.1; mail/components/migration/content/migration.css; new revision: 1.4.4.2; browser/base/content/searchDialog.css; new revision: 1.2.2.4; browser/themes/winstripe/browser/browser.css; new revision: 1.17.2.11;
Updated•18 years ago
|
Keywords: fixed1.8.1
Updated•18 years ago
|
Target Milestone: mozilla1.9alpha → mozilla1.8.1
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•