Closed Bug 305771 Opened 19 years ago Closed 19 years ago

Cannot create request flags with no requestee

Categories

(Bugzilla :: Attachments & Requests, defect)

2.21
defect
Not set
major

Tracking

()

RESOLVED FIXED
Bugzilla 2.22

People

(Reporter: LpSolit, Assigned: myk)

References

Details

(Keywords: regression, selenium)

Attachments

(1 file)

This is a regression due to bug 292022.

Flag::FormToNewFlags() is broken:

        if ($status eq "?") {
            foreach my $login ($cgi->param("requestee_type-$type_id")) {

If there is no requestee, we don't enter the FOREACH loop and no flag is created.
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.22
Keywords: regression
Assignee: LpSolit → myk
Attachment #193845 - Flags: review?(LpSolit)
Comment on attachment 193845 [details] [diff] [review]
patch v1: fixes problem

r=LpSolit
Attachment #193845 - Flags: review?(LpSolit) → review+
Flags: approval?
Flags: approval? → approval+
This regression was annoying me for too long. I did the checkin myself. ;)

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.51; previous revision: 1.50
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: testcase+
Keywords: selenium
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: