Closed
Bug 305771
Opened 19 years ago
Closed 19 years ago
Cannot create request flags with no requestee
Categories
(Bugzilla :: Attachments & Requests, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.22
People
(Reporter: LpSolit, Assigned: myk)
References
Details
(Keywords: regression, selenium)
Attachments
(1 file)
|
869 bytes,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
This is a regression due to bug 292022. Flag::FormToNewFlags() is broken: if ($status eq "?") { foreach my $login ($cgi->param("requestee_type-$type_id")) { If there is no requestee, we don't enter the FOREACH loop and no flag is created.
| Reporter | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.22
| Reporter | ||
Updated•19 years ago
|
Keywords: regression
| Assignee | ||
Comment 1•19 years ago
|
||
Assignee: LpSolit → myk
Attachment #193845 -
Flags: review?(LpSolit)
| Reporter | ||
Comment 2•19 years ago
|
||
Comment on attachment 193845 [details] [diff] [review] patch v1: fixes problem r=LpSolit
Attachment #193845 -
Flags: review?(LpSolit) → review+
| Reporter | ||
Updated•19 years ago
|
Flags: approval?
Updated•19 years ago
|
Flags: approval? → approval+
| Reporter | ||
Comment 3•19 years ago
|
||
This regression was annoying me for too long. I did the checkin myself. ;) Checking in Bugzilla/Flag.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v <-- Flag.pm new revision: 1.51; previous revision: 1.50 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•