305787 - build of modules/plugin/base/src fails

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[Shane Caraveo]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

Seems the makefile needs to add -I for widgets/src/gtksuperwin when building
with gtk2.  patch I am using will be attached.  This happens on suse 9.0 and 9.2.

Reproducible: Always

Comment 1

[Shane Caraveo]

Attachment: fix plugin build

Comment 2

[Shane Caraveo]

oh, one more note, this is against the 1.8 branch

Comment 3

[Johnny Stenback (:jst)]

I build gtk2 builds on linux all the time w/o needing this. What am I missing?

Comment 4

[Shane Caraveo]

Without the patch, if I run make in mozilla/modules/plugin/base/src, I end up
with the following error:

ns4xPluginInstance.cpp:74:25: gdksuperwin.h: No such file or directory
ns4xPluginInstance.cpp:75:24: gtkmozarea.h: No such file or directory
gmake[1]: *** [ns4xPluginInstance.o] Error 1
gmake[1]: Leaving directory
`/home/shanec/main/Apps/Mozilla-devel/build/firefox-cvs1.8-ko3.11-release-gtk2/mozilla/modules/plugin/base/src'
make: *** [all] Error 2

This is in the 1.8 branch.  I had been building on trunk back in early July,
then when 1.8 branched I tried again and got the error.  I haven't tracked down
what changed to cause the problem for me.

Comment 5

[Johnny Stenback (:jst)]

Is this still an issue?

Comment 6

[Johnny Stenback (:jst)]

Marking WORKSFORME per lack of recent evidence showing otherwise.