305799 - Add Live Bookmark / RSS icon UI changes for Firefox 1.5

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Mike Beltzner [:beltzner, not reading bugmail]]

The backout patch for feedview (bug 305134) moved the RSS icon / Add Live
Bookmark button into the URL bar where it is more discoverable. It also retained
the functionality that tries to be smart about cases where someones got the same
RSS feed in multiple formats, only presenting one to the user. This bug is to
handle some other small changes to the existing functionality for 1.5.

Those proposed changes are:

 - shorten the tooltip to "Add Live Bookmark..."
 - when >1 feeds exist, shorten the flyout text to be "Add %feedname; as Live
Bookmark ..."

as well as the sec 508 compliance changes in bug 304497 (marked as a dependency
for this bug).

Comment 1

[Grey Nicholson (they/them)]

Should this depend on bug 251447?

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

I don't think it should block, no, since bug 251447 (which I fully support, btw)
probably represents a non-trivial amount of work. We kinda got it for free with
feedview in that feedview DID parse the feed, but now that we're not doing that
again, we'd need a solution like the one proposed in bug 251447 comment 8.

Some points in that bug are valid, and we should probably adopt a change to get
around the case where there are multiple feeds that someone wants to bookmark on
a single page; in those cases, I think a smarter default name for the Live
Bookmark might be "&pageTitle; - &feedTitle;". Not perfect, but should cover a
lot of the cases. Thoughts?

Comment 3

[Daniel Steinbrook]

The glossary entry for "Live Bookmark" must now be updated (see bug 307955). 
Would you refer to its new location as the Address bar or the Location bar? 
We've had a little discussion about that over on the bug.  It's quite a debate
for a one-word change.

Comment 4

[Grey Nicholson (they/them)]

(In reply to comment #3)
> Would you refer to its new location as the Address bar or the Location bar? 
It's the Location Bar - see Help, For Internet Explorer Users.

Comment 5

[Daniel Steinbrook]

(In reply to comment #4)
> It's the Location Bar - see Help, For Internet Explorer Users.

Mouse over the Go button:
"Type a location in the address field"

Where's the consistency?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #5)
> Where's the consistency?

Oh, man, you gave me a good laugh, there! At any rate, if the UI is voting ...

- under File menu, "Open Location"
- in Toolbar customization, "Location"
- in modal dialog version, "Open Web Location"

... it would seem that the tooltip on the "Go" button is the odd-man out.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

This behaviour seems to have gotten fixed somewhere else, so marking WFM.

Comment 8

[Tanner M. Young [:tmyoung]]

Resetting QA Contact to default.