305808 - XUL popups without native themes look broken

Status: RESOLVED INCOMPLETE

(Toolkit :: Themes, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

With Native Themes being somewhat broken atm with Thebes-backed GFX,
non-native-theme looks pretty bad.  In particular, menus and tooltips don't set
a background color, so they never get cleared when opened -- under X, this means
they just retain whatever was underneath them on open.  The attached patch fixes
this; I'm pretty sure it shouldn't affect anything when native themes are in use.

Comment 1

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: thebes-xul-css.patch

Add some good defaults to XUL menu/popup CSS

Comment 2

[Boris Zbarsky [:bzbarsky]]

What about platforms or widget sets on which we don't do native theming?  We
have quite a number of these around, no?

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Right, I don't think this breaks anything on those platforms (and might even
make things better).

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

On second thought, I think that this is really only an xlib issue, and other
platforms won't notice; this only shows up because new xlib windows aren't
cleared when created.  (Just to make clear, I'm seeing this on a gtk2 build when
native theme stuff is disabled.)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Why?  For example, it styles active menuitems red.  This not only affects
platforms with no native theming but any theme which doesn't explicitly style
said menuitems (eg qute and winstripe; they style only menuitems that are kids
of specific other XUL tags).

I guess what I want is an explanation of each of those changes -- why it's
needed and why that value was selected -- in comment form next to the change.  I
assume you checked the IsWidgetStyled code to make sure that these changes won't
impact it?

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 193737 [details] [diff] [review]
thebes-xul-css.patch

Per comment 5.