305812 - Munger automatically converts invalid URL schemes into links

Status: NEW

(Other Applications :: ChatZilla, enhancement)

Description

[Oriyan Hermoni]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.11) Gecko/20050728
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.11) Gecko/20050728

The ChatZilla Munger automatically converts URLs such as irc:irc.mozilla.org
into a link, even though that scheme is wrong. Clicking on those kinds of links
generates "Invalid URL scheme" errors. It should instead only convert URLs such
as irc://irc.mozilla.org or http://www.mozilla.org to links.
URL schemes affected: jar:, http:, irc:, chrome:, gopher:, ftp:, and some others
which I can't remember at the moment.
I know this isn't an easy thing to fix, and the devs will only fix it if alot of
people complain, because it's not a serious bug. It's only annoying.

Reproducible: Always

Steps to Reproduce:
1. Enter a URL such as irc:something or http:/some.website into the input box
2. Send the message
Actual Results:  
The URL is converted to a link even though it's invalid.

Expected Results:  
The faulty URLs shouldn't be converted, and only valid URLs should have been
converted.

Error recieved after clicking the URL irc:foo - 'Invalid IRC URL ``irc:foo".'

Comment 1

[Samuel Sieb]

One way to fix this is to implement parsers for every url type, which isn't
going to happen, especially since it is very easy to add new url types to
mozilla.  The only other way I can think of is if you can actually pass the
string to the url handler to verify it, but I'm pretty sure that isn't possible.

Comment 2

[Robert Ginda]

we could keep a list of schemes we know don't (or do) need the //, and back out
of the linkification in the munger function if the url is missing //.  Sounds
like alot of work for a minor detail.  I prefer your original WONTFIX proposal,
actually :)

Comment 3

[Oriyan Hermoni]

I assumed it wouldn't be easy after Silver said so... and it's not a bug that's
a blocker or anything like that, it's only a simple nuisance. Just like the
errors you got when switching motifs and such, but that was a bigger annoyance
than this.
I was just hoping to get opinions, not patches. :P
If this bug is EVER going to be fixed, it would happen in a long time from now.

Comment 4

[James Ross]

Interesting point: current Bugzilla does link the "incorrect" schemes, without correcting them. Also, oddly, trunk Firefox is displaying the links in the statusbar as having the //, even though the href does not!