305821 - implement imgRequestProxy::GetStatus

Status: RESOLVED WONTFIX

(Core :: Graphics: ImageLib, defect)

Description

[timeless]

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/libpr0n/src/imgRequestProxy.cpp&rev=1.53&mark=206#202
203               /* readonly attribute nsresult status; */
204               NS_IMETHODIMP imgRequestProxy::GetStatus(nsresult *aStatus)
205               {
206                   return NS_ERROR_NOT_IMPLEMENTED;
207               }

Comment 1

[Nickolay_Ponomarev]

Fixed in bug 355555.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/libpr0n/src/imgRequestProxy.cpp

193               /* readonly attribute nsresult status; */
194               NS_IMETHODIMP imgRequestProxy::GetStatus(nsresult *aStatus)
195               {

196 dougt    1.57   if (!mOwner)
197                   return NS_ERROR_FAILURE;
198               
199                 *aStatus = mOwner->GetNetworkStatus();
200               
201                 return NS_OK;

202 pavlov   1.7  }

Comment 2

[Boris Zbarsky [:bzbarsky]]

Except that implementation is wrong.  For example, GetStatus() should return whatever status the request was canceled with if Cancel() is called, and this code doesn't do that.

Comment 3

[Joe Drew (not getting mail)]

We actually want imgIRequest to not be an nsIRequest (bug 692868), so we shouldn't do this.