305828 - Changes to tabbrowser.xml for sessionsaver extension

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Christian Schmidt]

The fix for bug 109672 in tabbrowser.xml introduced a problem with the
sessionsaver extension - see bug 109672 comment 23.

This is not really a bug in tabbrowser.xml, at least not in the basic
configuration without the sessionsaver extension. But the code could be made
more robust so that extensions like sessionsaver will nok break.

Comment 1

[Christian Schmidt]

Attachment: Updated version of the patch submitted in bug 109672 (attachment 186478)

Pike, could you verify that this fixes the problem with sessionsaver?

Comment 2

[PikeUK]

(In reply to comment #1)
> Pike, could you verify that this fixes the problem with sessionsaver?

Yes, I can confirm that this patch fixes the problem with SS 0.2.eur ,

Comment 3

[PikeUK]

(In reply to comment #2)
> Yes, I can confirm that this patch fixes the problem with SS 0.2.eur ,

That was supposed to end: "with SS 0.2.""

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 193750 [details] [diff] [review]
Updated version of the patch submitted in bug 109672 (attachment 186478 [details] [diff] [review])


Looks good to me; I'd prefer |for each| instead of |for (var i = 0; i <
foo.length; i++) { var p = foo[i]; ... }|, but the rest of the file does the
big for loop, so blah.

r=vladimir

Comment 5

[Christian Schmidt]

A lot of these loops could be cleaned up. AFAICS the |if (p)| part can be
omitted everywhere in tabbrowser.xml now that bug 303075 has been fixed. But I
suggest that we do this in another bug. The Sessionsaver people would like this
bug fixed soon.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Checked in on trunk.

Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.105; previous revision: 1.104
done

Comment 7

[:Gavin Sharp [email: [e-mail]]]

And the 1.8 branch.

Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.103.2.2; previous revision: 1.103.2.1
done

Comment 8

[PikeUK]

v.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050827
Firefox/1.6a1

Thanks Christian (and Vlad and Gavin).

Comment 9

[Asaf Romano (gone)]

filed regression... Bug 306208.

Comment 10

[moz_bug_r_a4]

This caused Bug 306243.
Please see Bug 306243 comment 24.