If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Changes to tabbrowser.xml for sessionsaver extension

VERIFIED FIXED in Firefox1.5

Status

()

Firefox
Tabbed Browser
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Christian Schmidt, Assigned: Christian Schmidt)

Tracking

({fixed1.8})

Trunk
Firefox1.5
fixed1.8
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
The fix for bug 109672 in tabbrowser.xml introduced a problem with the
sessionsaver extension - see bug 109672 comment 23.

This is not really a bug in tabbrowser.xml, at least not in the basic
configuration without the sessionsaver extension. But the code could be made
more robust so that extensions like sessionsaver will nok break.
(Assignee)

Comment 1

12 years ago
Created attachment 193750 [details] [diff] [review]
Updated version of the patch submitted in bug 109672 (attachment 186478 [details] [diff] [review])

Pike, could you verify that this fixes the problem with sessionsaver?

Comment 2

12 years ago
(In reply to comment #1)
> Pike, could you verify that this fixes the problem with sessionsaver?

Yes, I can confirm that this patch fixes the problem with SS 0.2.eur ,

Comment 3

12 years ago
(In reply to comment #2)
> Yes, I can confirm that this patch fixes the problem with SS 0.2.eur ,

That was supposed to end: "with SS 0.2.""
(Assignee)

Updated

12 years ago
Attachment #193750 - Flags: review?(vladimir)
Comment on attachment 193750 [details] [diff] [review]
Updated version of the patch submitted in bug 109672 (attachment 186478 [details] [diff] [review])


Looks good to me; I'd prefer |for each| instead of |for (var i = 0; i <
foo.length; i++) { var p = foo[i]; ... }|, but the rest of the file does the
big for loop, so blah.

r=vladimir
Attachment #193750 - Flags: review?(vladimir) → review+
(Assignee)

Comment 5

12 years ago
A lot of these loops could be cleaned up. AFAICS the |if (p)| part can be
omitted everywhere in tabbrowser.xml now that bug 303075 has been fixed. But I
suggest that we do this in another bug. The Sessionsaver people would like this
bug fixed soon.
(Assignee)

Updated

12 years ago
Attachment #193750 - Flags: approval1.8b4?

Updated

12 years ago
Attachment #193750 - Flags: approval1.8b4? → approval1.8b4+
(Assignee)

Updated

12 years ago
Whiteboard: [checkin needed]
Checked in on trunk.

Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.105; previous revision: 1.104
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox1.6-
And the 1.8 branch.

Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.103.2.2; previous revision: 1.103.2.1
done
Keywords: fixed1.8
Whiteboard: [checkin needed]
Target Milestone: Firefox1.6- → Firefox1.5

Comment 8

12 years ago
v.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050827
Firefox/1.6a1

Thanks Christian (and Vlad and Gavin).
Status: RESOLVED → VERIFIED
Blocks: 306208
filed regression... Bug 306208.

Comment 10

12 years ago
This caused Bug 306243.
Please see Bug 306243 comment 24.
Blocks: 306243
You need to log in before you can comment on or make changes to this bug.