305841 - Rename expat_s library name to mozexpat_s

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andy Willis (abwillis)]

To stay in keeping with other modules such as cairo (mozcairo and mozlibpixman)
I propose to rename the library name of expat from expat_s to mozexpat_s.  On
OS/2 the current naming convention is causing the cairo build to fail when it
looks for -lexpat as it finds the Mozilla one which causes unresolved externals.  
The patch I'll be attaching takes care of this and should take care of all
internals looking for expat_s.

Comment 1

[Andy Willis (abwillis)]

Attachment: Changes expat_s to mozexpat_s

Comment 2

[Boris Zbarsky [:bzbarsky]]

Andy, did this ever get checked in?  If not, should I go ahead and check it in?

Comment 3

[Andy Willis (abwillis)]

No, this has not been checked in yet (sorry for the delay in response, I had apparently changed the settings on bugmail to not send me changes when I was the reporter... just fixed that which is what prompted me to check the bugs I had reported).  If this can be checked in I would appreciate it thanks.

Comment 4

[Andy Willis (abwillis)]

Attachment: Corrected for bitrot

Not sure if I could bring forward the r+ so I am requesting review again.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 207689 [details] [diff] [review]
Corrected for bitrot

Carrying over peterv's review; this is the same patch but updated to the new in-tree location.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Fixed on trunk.  Andy, thanks for the patch!