305843 - Update timer fires every 5 seconds

Status: VERIFIED FIXED

(Toolkit :: Application Update, defect)

Description

[Mike Pinkerton (not reading bugmail)]

If you put a dump in the background notification timer for the update service,
you see that it fires every five seconds.

  var timerInterval = getPref("getIntPref", PREF_APP_UPDATE_TIMER, 5000);

and this pref isn't set to anything else by any pref files that i could find
with lxr (it's not set in firefox.js). 

This seems pretty bad to have this constantly running with such a short interval
for no good reason.

Comment 1

[Mike Pinkerton (not reading bugmail)]

cc'ing ben so he'll read the bug and requesting blocking status.

Comment 2

[Ben Goodger (use ben at mozilla dot org for email)]

This pref controls a timer which checks if the update interval has expired yet.
We need to have this kind of model because long timers seem to be buggy and
seriously disturb some of the tinderboxes. 

With that said, we could raise this value to something higher than 5000 now the
background update system has been tested and has been shown to work fairly
effectively.

Maybe set it to 600000? (600 seconds, 10 minutes)

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: patch to do just that

Comment 4

[Brett Wilson]

Comment on attachment 193951 [details] [diff] [review]
patch to do just that

r=[e-mail]

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

landed branch and trunk. 

Comment 6

[Scott MacGregor]

FYI, I made this change to Thunderbird as well. 

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: supplimental patch to make the comment match the default pref

while looking into an other issue, I noticed the comment does not match the code.  here's the fix.  (note seamonkey, http://lxr.mozilla.org/seamonkey/source/suite/browser/browser-prefs.js#247, is already correct)

Comment 8

[(not reading, please use [e-mail] instead)]

trivial supplimental fix checked in.

Checking in browser/app/profile/firefox.js;
/cvsroot/mozilla/browser/app/profile/firefox.js,v  <--  firefox.js
new revision: 1.171; previous revision: 1.170
done
Checking in mail/app/profile/all-thunderbird.js;
/cvsroot/mozilla/mail/app/profile/all-thunderbird.js,v  <--  all-thunderbird.js
new revision: 1.89; previous revision: 1.88
done
Checking in calendar/sunbird/app/profile/sunbird.js;
/cvsroot/mozilla/calendar/sunbird/app/profile/sunbird.js,v  <--  sunbird.js
new revision: 1.40; previous revision: 1.39
done