Popup notification bar doesn't appear on first load (e.g. if your homepage tries to open a popup) , and doesn't correctly list all blocked popups

VERIFIED FIXED in Firefox 2 alpha1

Status

()

Firefox
General
P2
normal
VERIFIED FIXED
13 years ago
12 years ago

People

(Reporter: Gavin, Assigned: Gavin)

Tracking

({verified1.8.1})

Trunk
Firefox 2 alpha1
verified1.8.1
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

While fixing bug 304727, I noticed two bugs with blocked popup notification:

1) If the first page loaded has a blocked popup, the popup notification bar
doesn't appear as it should.
2) If multiple popups are blocked, the popup notification message doesn't
correctly indicate that ("x popups were blocked ...")

In both cases, switching tabs updates the message correctly.

Patch coming up.
Created attachment 193814 [details] [diff] [review]
patch

Creates the pref service if it doesn't exist when receiving the first
onPopupBlocked event, and updates the browser message after each onPopupBlocked
so that the correct count is displayed the first time.
Attachment #193814 - Flags: review?(mconnor)
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → Firefox1.6-
Comment on attachment 193814 [details] [diff] [review]
patch

this works for now, but I think we need to a) check all usage of gPrefService
here and b) add a helper function like ensurePrefService() so its less ugly. 
Can you file a followup and nominate for blocking-aviary2.0 please?
Attachment #193814 - Flags: review?(mconnor) → review+
Checking in toolkit/content/widgets/browser.xml;
/cvsroot/mozilla/toolkit/content/widgets/browser.xml,v  <--  browser.xml
new revision: 1.74; previous revision: 1.73
done
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.497; previous revision: 1.496
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Flags: blocking-aviary2?
Attachment #193814 - Flags: approval1.8.1?

Updated

12 years ago
Attachment #193814 - Flags: approval1.8.1? → approval1.8.1+

Updated

12 years ago
Flags: blocking-firefox2? → blocking-firefox2+
Checked in on the 1.8 branch for Firefox 2.
mozilla/browser/base/content/browser.js; new revision: 1.479.2.46;
mozilla/toolkit/content/widgets/browser.xml; new revision: 1.70.2.4;
Keywords: fixed1.8.1
Target Milestone: Firefox 2 → Firefox 2 alpha1
VERIFIED FIXED:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060819 BonEcho/2.0b2
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060821 Minefield/3.0a1
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in before you can comment on or make changes to this bug.