305926 - Crash when software update tries to start new version of firefox

Status: RESOLVED WORKSFORME

(Toolkit :: Application Update, defect)

Description

[Dave Townsend [:mossop]]

I had the 2005082501 trunk build of firefox installed and it downloaded the
update for the new nightly trunk. On restarting the update progress bar appeared
as normal and went to the end, then when that finished and it was starting
firefox it crashed displaying the standard windows "firefox.exe has encountered
a problem and needs to close".

Talkback did not run for some reason.

After cancelling the crash dialog I could start firefox normally and it worked
fine with the new version being 2005082507.

I still have the installer for that earlier build so I tested a couple of times
and each time the crash occured.

Comment 1

[Dave Townsend [:mossop]]

FWIW I got this again when updating to the nightly for 26th. Not entirely sure
what else I can do to track down what is going on here, any suggestions?

Comment 2

[Dave Townsend [:mossop]]

I started Visual Studio as a debugger when the latest crash happened, but it
doesn't give me much other than a dissambly which I assume is pretty useless. It
did give this further error:

Unhandled exception at 0x00530557 in firefox.exe: 0xC0000005: Access violation
reading location 0x00000000.

Comment 3

[Dave Townsend [:mossop]]

I've narrowed this down to an odd setting in my profile. Having the pref
app.update.showInstalledUI set to true seems to reliably cause software update
to crash for me. Oddly I can't find anything in the code that sets this to true.
The only place I can see that reads this pref is:

http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/update/src/nsUpdateService.js.in#2350

Comment 4

[Dave Townsend [:mossop]]

With the pref set, this crashes branch builds as well.

Comment 5

[Ben Goodger (use ben at mozilla dot org for email)]

It is never set to true in firefox... it is set to true in thunderbird... does
it crash there?

Comment 6

[Dave Townsend [:mossop]]

Tried thunderbird. It wasnt set to true there but I set it to true and updating
did not crash. I did get a message after the restart that an update was
available to thunderbird which I thought a bit odd but that may be another issue
I've heard about today.

I guess this isn't an issue for the time being?

Can't quite figure out how I've ended up with a true setting for that pref in my
firefox profile, I generally don't change prefs manually unless I know what they
are.

Comment 7

[Darin Fisher]

going to mark WORKSFORME for now.. please reopen this bug if you find the
problem appearing again.  thanks!