305928 - add bookmark dialog - expand button does not expand

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050825
Firefox/1.0+ ID:2005082506

1.Open FF and any page
2.Press Bookmark this page
3.Press the "expand" button
4.the folder does not expand but adds the [New Folder] button instead

Comment 1

[Asaf Romano (gone)]

only hapeens when "Bookmarks" is selcted.

JS Console says:
Error: uncaught exception: [Exception... "Component returned failure code:
0x80004003 (NS_ERROR_INVALID_POINTER) [nsIBookmarksService.getParentChain]" 
nsresult: "0x80004003 (NS_ERROR_INVALID_POINTER)"  location: "JS frame ::
chrome://browser/content/bookmarks/bookmarksTree.xml :: selectResource :: line
293"  data: no]

Comment 2

[Gary Elshaw]

seen here too on branch Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
rv:1.8b4) Gecko/20050825 Firefox/1.0+ (OS X 10.4.2)

Comment 3

[Peter van der Woude [:Peter6]]

Same JSC error when a live bookmark is added (via locationbar icon)

Comment 4

[Magnus Melin [:mkmelin]]

Clicking the "Add" button doesn't work either :( Mozilla/5.0 (X11; U; Linux
i686; en-US; rv:1.8b4) Gecko/20050825 Firefox/1.0+

Comment 5

[Mike Connor [:mconnor]]

Attachment: stupid

stupid.  This collided with ben's backout of feedview on branch because he
included a fix for 304705 in the patch, which I didn't pick up on in my quick
reading of the patch.  Gah.  This removes what he added as the simplest means
to resolve the conflict between our patches.

Comment 6

[Jay Patel [:jay]]

v.fixed in both places with today's builds.