305941 - Remove refreshed_when from profiles and last_changed from groups

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Joel Peshkin]

They are no longer needed.

Comment 1

[Frédéric Buclin]

The trunk is now frozen to prepare Bugzilla 2.22. Enhancement bugs are retargetted to 2.24.

Comment 2

[Dave Miller [:justdave]]

groups.last_changed might actually be useful if we exposed it in the UI in editgroups for example.

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> groups.last_changed might actually be useful if we exposed it in the UI in
> editgroups for example.
> 

We actually have no UI for it. Do we plan to implement it? We cannot remove this column now and add it again later; we would probably break checksetup.pl.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1

Comment 5

[Max Kanat-Alexander]

Comment on attachment 232197 [details] [diff] [review]
patch, v1

It's bz_drop_column, not drop_column.

Comment 6

[Frédéric Buclin]

Attachment: patch, v1.1

s/drop_column/bz_drop_column/

Comment 7

[Frédéric Buclin]

Attachment: unbitrotten patch, v1.2

Comment 8

[Max Kanat-Alexander]

Comment on attachment 232200 [details] [diff] [review]
unbitrotten patch, v1.2

Yeah, looks good. I ran a few tests, and I checked that last_changed and refreshed_when are totally gone from the code, and everything is good.

Comment 9

[Frédéric Buclin]

Checking in checksetup.pl;
/cvsroot/mozilla/webtools/bugzilla/checksetup.pl,v  <--  checksetup.pl
new revision: 1.537; previous revision: 1.536
done
Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.78; previous revision: 1.77
done
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.128; previous revision: 1.127
done
Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.130; previous revision: 1.129
done
Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.121; previous revision: 1.120
done
Checking in Bugzilla/Group.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v  <--  Group.pm
new revision: 1.14; previous revision: 1.13
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.123; previous revision: 1.122
done
Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.59; previous revision: 1.58
done
Checking in Bugzilla/Install/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Install/DB.pm,v  <--  DB.pm
new revision: 1.5; previous revision: 1.4
done