Closed
Bug 305946
Opened 19 years ago
Closed 19 years ago
lib/browserconfig.properties is installed as a symlink to version in build dir, not as an actual file
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: niederstrasser, Assigned: niederstrasser)
Details
(Keywords: fixed1.8)
Attachments
(1 file)
|
562 bytes,
patch
|
benjamin
:
review+
benjamin
:
approval1.8b4+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6 Using a MOZILLA_1_8_BRANCH firefox CVS tree pulled today, the file mozilla/browser/base/content/browserconfig.properties is installed as a symlink that points to the file in the build dir. This does NOT happen in 1.0.6 under identical build conditions. A 1.0.6 install includes the actual file. The exact install command from the build log for the 1.8 branch build is ** /sw/src/fink.build/firefox-trunk-1.1-11/mozilla/config/nsinstall -L /sw/src/fink.build/firefox-trunk-1.1-11/mozilla/browser/base ./content/browserconfig.properties ../../dist/bin ** This install command is not seen in the 1.0.6 build log. The relevant file seems to be mozilla/browser/base/Makefile.in, which was changed from using a perl preprocessor to config/nsinstall around the time this started (see bug 282057). Reproducible: Always
| Assignee | ||
Comment 1•19 years ago
|
||
changes the dangling symlink to be an actual file
Attachment #193980 -
Flags: review?(benjamin)
| Assignee | ||
Comment 2•19 years ago
|
||
Should point out that this is in both trunk and in MOZILLA_1_8_BRANCH builds.
Updated•19 years ago
|
Attachment #193980 -
Flags: review?(benjamin)
Attachment #193980 -
Flags: review+
Attachment #193980 -
Flags: approval1.8b4+
Updated•19 years ago
|
Assignee: nobody → niederstrasser
Status: UNCONFIRMED → NEW
Ever confirmed: true
| Assignee | ||
Comment 3•19 years ago
|
||
Fixed on a fresh branch CVS pull.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•