305947 - Comparison in nsCSSScanner::ParseRef is always false

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsCSSScanner.cpp has this code:
  PRUnichar ch = Read(aErrorCode);
  if (ch < 0) {
    return PR_FALSE;
  }

However, a PRUnichar is an unsigned data type. The return value of Read is
PRInt32, presumably due to exactly that reason. Probably ch should be a PRInt32.

This is in PRBool nsCSSScanner::ParseRef, last touched by bz in Bug 299148.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

ch should be a PRInt32, like it is everywhere else.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2005-08-26 22:59 -0700.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 193838 [details] [diff] [review]
patch

Trivial fix to earlier patch to correct EOF handling.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to MOZILLA_1_8_BRANCH, 2005-08-29 12:35 -0700.