305948 - Use the "stop" icon from the main toolbar in download manager rather than the current icon

Status: RESOLVED WONTFIX

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Bruce Davidson]

Currently we have two icons representing "stop loading":
1. The stop icon (red circle with white cross through it) on the main toolbar
2. The cancel icon (a red octagon) on the download manager toolbar

I think we should use the same icon for both, as they do effectively the same
action. To my mind the one in the main toolbar is better and should be the one
selected.

Comment 1

[Samuel Sidler (old account; do not CC)]

Also be sure to remove the icon from our package if we're not using it 
elsewhere (I don't believe we are...).

Comment 2

[Jasper]

Bruce, care to have a look here?

Comment 3

[Markus Amalthea Magnuson]

Attachment: Changes the stop-sign icon to the regular stop icon, for the download toolbar.

As mentioned in Samuel Sidler's comments, dl_cancel.tif (the stop-sign icon)
should be removed from the file tree. Someone with CVS access should do this,
as I haven't.

Comment 4

[Samuel Sidler (old account; do not CC)]

Comment on attachment 200372 [details] [diff] [review]
Changes the stop-sign icon to the regular stop icon, for the download toolbar.

I've spent countless hours on my first review request. I've laboured and
toiled, wasted away, ensuring every "i" is tittled, every "t" crossed, all so I
can say, for the first time, and with the help of irc:

r=me

That said, do we really want this? I almost think it's nice having separate
icons, even if they do mean the same thing. Jasper, is this something you want?
In one case we're "stopping a download", in another "canceling the request". I
suppose you stop requests, but for whatever reason, that wording ran in my
mind.

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FWIW, I think in the DL Mgr toolbar, the different shape (octogon) of the "stop"
icon helps more easily visually distinguish it from "remove", and they're right
next to each other in the default set.

Comment 6

[Markus Amalthea Magnuson]

I think of it this way: The stop button is for stopping the loading of a stream
of data. Be it a file or a page. The only _actual_ difference between these two
things is that a download is written permanently to disk, while page is only
written in a temporary cache. But since these two things are essentially the
same, they should have the same icon.

Comment 7

[Markus Amalthea Magnuson]

Someone else care to comment on this?

Comment 8

[Jasper]

Well as I proposed to do this I can only say that I can't add much more to the reasoning by Markus Magnuson. Except that I think that doing this would add consistany aswell, which is a big thing to me.

Comment 9

[Mike Pinkerton (not reading bugmail)]

i do agree they are the same action, but i think the stop icon in the d/l manager makes a lot more sense. it doesn't have to fit in with the toolbar scheme and it's differntiation in color and shape from the two buttons next to it help user selection.

i think if you take our toolbar stop icon out of context (back/fwd/reload/stop, which everyone just knows), i don't think people would necessarily get at first glance that it's stop.

Comment 10

[Jasper]

Come on why does this need to be so hard to change guys. It's just silly to say that the icon wouldn't work if it wasn't in the toolbar, since that won't ever happen.

In the light of Nick working on the "Reload" feature for the downloads, which will be the switched state of the "Stop" icon. I thought it would be good to have both icons to have the same round button basic shape and let it change from the stop to the reload icon.

I really think this is a silly discussion, it's a tiny trivial change, and I wonder why there is "so much" resentment.

Comment 11

[Samuel Sidler (old account; do not CC)]

Comment on attachment 200372 [details] [diff] [review]
Changes the stop-sign icon to the regular stop icon, for the download toolbar.

Clearing review request...