305992 - nsIVersionComparator is broken in some circumstances

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Dave Townsend [:mossop]]

Seems since the last patch for bug 300731 the version comparator is broken.

compare("0.7","0.7.3") returns 1 (should be -1)
compare("0.7.2","0.7.3") returns -1

Also can we please clean up the confusing comment in nsIVersionComparator.idl

Comment 1

[Dave Townsend [:mossop]]

Just testing a patch for this.

Comment 2

[Dave Townsend [:mossop]]

Attachment: Initialises version part properly when the string is empty

In the case of an empty string, numA of the version part was not being
initialised.
Also included the change to the comment in nsIVersionComparator.idl.

Comment 3

[Justin Bradford]

My apologies. I wrote the previous patch, and I did test it, but I guess my
debug build zeroed out the struct for me. Anyway, for what it matters, this is
the correct fix. I'd give you the r and a if I could. Sorry for the trouble.

Comment 4

[Dave Townsend [:mossop]]

Mistakenly assigned to the wrong person again, sorry.

Comment 5

[Mike Shaver (:shaver emeritus)]

Comment on attachment 193873 [details] [diff] [review]
Initialises version part properly when the string is empty

sr+a=shaver

Comment 6

[Benjamin Smedberg]

fixed, trunk and 1.8branch