305993 - The requestee field may be omitted even when a requestee is already set

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect)

Description

[Frédéric Buclin]

Flag.pm says:

        # Make sure the user didn't specify a requestee unless the flag
        # is specifically requestable. If the requestee was set before
        # the flag became specifically unrequestable, leave it as is.

But template/en/default/flag/list.html.tmpl displays the requestee field only when:

        [% IF any_flags_requesteeble %]
          <td>
            [% IF type.is_active && type.is_requesteeble %]

That means that if a requestee was initially set and now the flag is no longer
specifically requestable, the requestee field will not be displayed anymore
despite a requestee is given.

Not only the requestee is not visible anymore, but the next time the bug or the
attachment is edited, the requestee will be (silently) removed, which is not wanted!

Comment 1

[Dave Miller [:justdave]]

If someone edits a flag to make it no longer specifically requestable, it ought to remove all the requestees (and warn the admin doing it that it's going to do so first).

Comment 2

[Frédéric Buclin]

Probably not that easy to fix, so removing [Good Intro Bug].

Comment 3

[Frédéric Buclin]

We are freezing the code for 3.0 in two weeks and we don't expect this bug to be fixed on time.

Comment 5

[timeless]

lpsolit? my bug is about disabled, not !specifically_requestable.

justdave's comment seems to imply that you're talking about a bug that lost its specifically_requestable bit.

we explicitly want to be able to have requested flags that are pending but for which no new pending flags may be added.

Comment 6

[Frédéric Buclin]

Attachment: patch, v1

This patch depends on code which landed in bug 415541, so we cannot take it for 3.4. So r+'ing myself as module owner for flags.

Comment 7

[Frédéric Buclin]

Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.158; previous revision: 1.157
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.288; previous revision: 1.287
done