306035 - mail server appended to usernames with "@" (Password dialog for IMAP says <alias>@<domain>@<mailserver> instead of <alias>@<domain> on(at/...) <mailserver>)

Status: RESOLVED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Ignacio Coupeau]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

If the user name has the form <alias>@<domain>, the window askink the passwd says:

v 1.0.2/1.0.6 POP & IMAP: ERROR: Enter your password for:
<alias>@<domain>@<mailserver>
and fails

v Gecko/20050716 POP: OK : says Enter your password for: 
<alias>@<domain> on <mailserver>

v Gecko/20050716 IMAP: BUG: says Enter your password for: 
<alias>@<domain>@<mailserver> 
but runs well because internally uses <alias>@<domain>


Reproducible: Always

Steps to Reproduce:
1.username <alias>@<domain> form
2.log in the account
3.

Actual Results:  
The sortcut for 1.0.2/1.0.6 versions is append a blank space after teh user
name, so is internally truncated and the login goes well.
username: <alias>@<domain>[WS]
<alias>@<domain>[WS]@<mailserver> internally truncated to <alias>@<domain>


Versions 1.0.2, 1.06, Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10)
Gecko/20050716 Firefox/1.0.6

Comment 1

[Ignacio Coupeau]

*** Bug 306146 has been marked as a duplicate of this bug. ***

Comment 2

[Michal Golka]

I suppose it is a problem with users like: [e-mail], where 
domain beginns with a number.  This is translated on hex user%402msoftware....

Comment 3

[Yfrwlf]

I'm pretty sure this bug still exists, as when you are asked for your account password, it says "Enter your password for <USER@NAME>@<FULL.SERVER.NAME>

That's not right.  The user name does not include the server name.  It should say "Enter your password for user <ACTUALUSER@NAME>" or "Enter your password for account <ACCOUNT NAME>" or "Enter your password for mail server <FULL.SERVER.NAME>" or "Enter your password for mail server <FULL.SERVER.NAME> for user <full.user.name.regardless.of.if.there.is.an@symbol>".

I can't connect to get mail, and I don't know if it's because Thunderbird is putting in the wrong user name because of this, or if it's because the password is wrong, or if it's because the port is being blocked.  It'd be a lot easier if this bug didn't exist so I could rule out the former. :)

Thunderbird version 2.0.0.9 (20080214)
Ubuntu 8.04 beta 5 kernel 2.6.24-8 (also happened on Ubuntu 7.10)

Comment 4

[RKopacz]

I installed Thunderbird about a month ago and all was fine, and all of a sudden this started happening. Then it stops, and all of a sudden it starts again. Uninstalled, redownloaded to make sure I have the most recent version, went in and deleted my profile and then started from scratch; same thing after all that. It looks like this has been around for a long time and nobody seems to have picked up the ball to fix it. I guess that's the problem with this type of freeware. When something goes wrong there is no one to call with an answer.

Comment 5

[WADA:World Anti-bad-Duping Agency]

(In reply to comment #4)
> I installed Thunderbird about a month ago and all was fine, and all of a sudden
> this started happening. Then it stops, and all of a sudden it starts again.

Upon initial password asking after removal of password entry of password manager, Tb trunk(2009/4/08 build) displayed following string in password dialog:
 (a) SMTP : <alias>@<domain> on <mailserver>  <= Already fixed some years ago
 (b) POP3 : <alias>@<domain> at <mailserver>  <= Already fixed some years ago
 (c) IMAP : <alias>@<domain>@<mailserver>     <= This bug

RKopacz, you are saying next?
  1. You did see string like (a) or (b) for an IMAP account initially.
  2. You suddenly experienced string like (c) for same IMAP account.
  3. String like (c) stopped for same IMAP account, and string was changed to
     one of (a) or (b).
  4. Suddenly, string was changed to (c) again for same IMAP account.
Or you saw (a) / (b) / (c) randomly for SMTP / POP3/ IMAP?

(In reply to comment #3)
> I can't connect to get mail,

This bug is for problem of misleading/confusing/incorrect-for-user string of "<alias>@<domain>@<mailserver>" in password dialog for IMAP(should be "<alias>@<domain> on/at/... <mailserver>").
String of "<alias>@<domain>@<mailserver>" in password dialog will never produce connection error.
Yfrwlf, is cause of your "can't connect" really this confusing string?

Comment 6

[RKopacz]

(In reply to comment #5)
> (In reply to comment #4)
> > I installed Thunderbird about a month ago and all was fine, and all of a sudden
> > this started happening. Then it stops, and all of a sudden it starts again.
> 
> Upon initial password asking after removal of password entry of password
> manager, Tb trunk(2009/4/08 build) displayed following string in password
> dialog:
>  (a) SMTP : <alias>@<domain> on <mailserver>  <= Already fixed some years ago
>  (b) POP3 : <alias>@<domain> at <mailserver>  <= Already fixed some years ago
>  (c) IMAP : <alias>@<domain>@<mailserver>     <= This bug
> 
> RKopacz, you are saying next?
>   1. You did see string like (a) or (b) for an IMAP account initially.
>   2. You suddenly experienced string like (c) for same IMAP account.
>   3. String like (c) stopped for same IMAP account, and string was changed to
>      one of (a) or (b).
>   4. Suddenly, string was changed to (c) again for same IMAP account.
> Or you saw (a) / (b) / (c) randomly for SMTP / POP3/ IMAP?
> 
The bug is (c), and I experienced as you describe in (1-4) above. I only use IMAP on Thunderbird. Yes, sometimes works, sometimes dialog box appears, declares that I did not save password (when I did), asks for password and text string is as in (c) above. When I enter password, login fails. When a normal string appears, it is like (a). Events are random. Thank you.

Comment 7

[Viktor]

I had version 2., suddenly experiencing (c) for my only IMAP after downloading the latest 3.0 nightly about 2 weeks ago but then it did not help anymore returning to 3.0b2, new profile, whatever. The normal string never appeared again. My POP3 accounts work properly.

Comment 10

[rsx11m]

(Quoting bug 635911 comment #3)
> Agreed, the "double-@" notation is frequently irritating for the user. The
> difference is likely that the POP password prompt uses a named property
> (pop3EnterPasswordPrompt) for which multiple arguments can be specified for
> formatting, whereas it's IMAP counterpart uses a numerical ID (5047) and
> GetFormattedStringFromID() doesn't allow to specify multiple strings.

Comment 11

[:aceman]

Attachment: patch

Yeah I have seen it now and it looks ugly. This should fix it.

Comment 12

[[e-mail]]

Comment on attachment 8577550 [details] [diff] [review]
patch

>-imapEnterPasswordPrompt=Enter your password for %S:
>+imapEnterPasswordPrompt=Enter your password for %1$S on %2$S:
Need to rename the string.

>-  IMAPGetStringByName("imapEnterPasswordPromptTitle",
>-                      getter_Copies(passwordTitle));
Need to remove the #include "nsImapStringBundle.h"

>+  nsAutoString finalUserName;
>+  nsAutoString finalHostName;
>+  CopyASCIItoUTF16(userName, finalUserName);
>+  CopyASCIItoUTF16(hostName, finalHostName);
NS_ConvertASCIItoUTF16 finalUserName, userName; etc.

Comment 13

[:aceman]

Attachment: patch v2

Comment 14

[[e-mail]]

(In reply to comment #12)
> >+  nsAutoString finalUserName;
> >+  nsAutoString finalHostName;
> >+  CopyASCIItoUTF16(userName, finalUserName);
> >+  CopyASCIItoUTF16(hostName, finalHostName);
> NS_ConvertASCIItoUTF16 finalUserName, userName; etc.
Sorry I meant to write NS_ConvertASCIItoUTF16 finalUserName(userName); here.

Comment 15

[:aceman]

Attachment: patch v2.1

OK, thanks

Comment 16

[:aceman]

Thanks.

Comment 17

[Philip Chee]

Comment on attachment 8588273 [details] [diff] [review]
patch v2.1

a=me for SeaMonkey CLOSED TREE

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/comm-central/rev/33593fa70bb9