306040 - "Reload remote calendars" doesn't work

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[石庭豐 (Seak, Teng-Fong)]

I've found that there're several bugs about this bug and they're marked as
RESOLVED, but I really doubt it's resolved.

Version: I had Sunbird 0.2 release and I've just download the nightly built 0.2+
20050825 and the problem is still there.

I've done several times the same test, here are the steps:
Delete my sunbird profile.
Open Sunbird so that it creates a new one for me.
Associate a calendar with a remote ICS calendar (I use http://www.icalx.com/......).
Right-click on the calendar to select "Reload remote calendars" (or from menu
File, but I suppose they're the same).

The remote calendar is never reload.

In Sunbird 0.2, the only way to trigger the reload is to create a bogus event
locally, then Sunbird would connect to ICS server and find that it needs a
password and display a popup to ask for password.  After this, the remote
calendar is reloaded, and I have to delete the bogus event!

In Sunbird nightly built, even this trick doesn't work!

Comment 1

[Joey Minta]

(In reply to comment #0)
> Associate a calendar with a remote ICS calendar (I use
http://www.icalx.com/......).

Right now this bug seems to be WFM, and this is the step I'm wondering about. 
The normal procedure would be to create a new webdav calendar with the address
you're refering to.  If you're trying to change an existing calendar to refer to
the remote one, then this may be a dupe of bug 217197.

Can you clarify what you're doing here?

Comment 2

[石庭豐 (Seak, Teng-Fong)]

I could redo the whole procedure again, but first tell me which version you
would like me to try.  0.2 or 0.2+?  I asked so because they're very different
(esp GUI).

But I remember that in 0.2+, I've created a new CalDAV (not WebDAV, but are they
very different?) and tried to reload it without success.

Comment 3

[Joey Minta]

(In reply to comment #2)
> I could redo the whole procedure again, but first tell me which version you
> would like me to try.  0.2 or 0.2+?  I asked so because they're very different
> (esp GUI).

Definitely 0.2+.

> But I remember that in 0.2+, I've created a new CalDAV (not WebDAV, but are they
> very different?) and tried to reload it without success.

They're a bit different, yes.  I'm actually not completely sure what our caldav
status is.  dmose would know more.  But please try with a nightly build and a
webdav calendar.

Comment 4

[石庭豐 (Seak, Teng-Fong)]

The lastest build has a serious GUI problem which prevents testing:
https://bugzilla.mozilla.org/show_bug.cgi?id=306143

So I use the 2005.08.25 build.

I've removed my profile and this time I created a remote calendar using WebDAV
and it works!!  It loads automatically remote calendar.  So the problem is CalDAV.

IMO, I think those two words (WebDAV and CalDAV) need more explanations because
people like me don't know the difference and don't really know what they are in
fact.  I just learnt about what ICS is.

BTW, "File > Open Calendar file" has no reaction, while "File > New Calendar
file" has the same effect as "File > Subscribe to remote".  These last two item
should be merged as one.  Should I file a separate bug for it?

Lastly, it would be nice the "Go to Today" icon be displayed as a default icon
together with "Day view", "Week view", etc.  Need to file a bug for it too?

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

(In reply to comment #4)
>
> IMO, I think those two words (WebDAV and CalDAV) need more explanations because
> people like me don't know the difference and don't really know what they are in
> fact.  I just learnt about what ICS is.

We should be able to make the software autodetect the calendar type so that the
user never needs to make this choice at all.  I just iled bug 306495 for this.

> BTW, "File > Open Calendar file" has no reaction, while "File > New Calendar
> file" has the same effect as "File > Subscribe to remote".  These last two item
> should be merged as one.  Should I file a separate bug for it?

Yes, please.

> Lastly, it would be nice the "Go to Today" icon be displayed as a default icon
> together with "Day view", "Week view", etc.  Need to file a bug for it too?

Yes; thanks!

Comment 6

[石庭豐 (Seak, Teng-Fong)]

Sorry to reopen this bug, but I've the same bug again.
Very strange, and I don't understand.  I'm using the same 08.25 build (and later
on the 08.31) but the problem is the same.  Maybe I forgot to do a clean install
(remove the Sunbird program directory *in addition to* removing my profile
directory) in comment #4. Then I've done the same test again without removing
the Sunbird program directory but I still can't make it work.

I noticed that after I click the Finish button to create the remote calendar, I
get this error message in JS console:

Error: [Exception... "Component returned failure code: 0x8000ffff
(NS_ERROR_UNEXPECTED) [nsIScriptableUnicodeConverter.convertFromByteArray]" 
nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)"  location: "JS frame ::
file:///C:/PROGRA~1/MOZILL~1.2_/components/calICSCalendar.js :: anonymous ::
line 160"  data: no]
Source File: file:///C:/PROGRA~1/MOZILL~1.2_/components/calICSCalendar.js
Line: 160

And then later on I got this (but I don't know how and when I've triggered it):
Error: calendarManagerDNDObserver is not defined
Source File: chrome://calendar/content/calendar.xul
Line: 1



PS: I've filed the other two unrelated bugs
https://bugzilla.mozilla.org/show_bug.cgi?id=306692
https://bugzilla.mozilla.org/show_bug.cgi?id=306693

Comment 7

[Joey Minta]

(In reply to comment #6)
If the unicode converter is failing, that could easily be caused by non-unicode
characters being present in the file.  Any idea if this is the case?

The DND error isn't related.

Comment 8

[石庭豐 (Seak, Teng-Fong)]

Yes, that's what I was doing.  I've downloaded the whole ics file from icalx.com
and found that one event contains a character in wrong encoding:
it's an 'é' character which is saved as \xE9 (Latin-1) instead of \xC3 \xA9
(UTF-8).  That event was definitely created using a 0.2+ version (but I can't
tell which build).

I've correctly the error using a binary editor, but I don't see how to upload
the whole file back to icalx.com without using iCal program. :-/

Comment 9

[石庭豐 (Seak, Teng-Fong)]

OK, yes!  I can confirm that the problem cause is SB's recent build (or even
earlier).  It uploads characters in Latin-1 instead of UTF-8, and the next time
SB is run, it can no more reload the remote calendar!!  This serious bug is
filed as:

https://bugzilla.mozilla.org/show_bug.cgi?id=306765

Nevertheless, I think this bug should remain open because even if SB does (try
to) load remote calendar, it breaks when the data isn't good.  So the effect is
the same: "reload remote calendar" doesn't work.

IMO, SB should behave like version 0.2 which loads the whole calendar anyway
even if there're encoding errors.  (That's how I managed to reload the ical and
correct it and upload it to do the tests).

Or even better, SB should display a dialog to user showing the string which
contains wrong data and ask the user to correct it manually.

Comment 10

[Joey Minta]

We got the unicode converter problem fixed.  Is there anything left to do in this bug?

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

I believe that in combination with your error-reporting / read-only work, we should now load the calendar (but set it read only) even if encoding errors are detected.  I think this bug can be closed. 

I suspect, however, that the events with encoding errors will be discarded.  This isn't totally unreasonable, but it might be worth allowing the user to try and recover such events at some point down the road, so feel free to file a new bug on that.