306052 - Fill Spotlight Comments data with data from bookmark descriptions

Status: RESOLVED FIXED

(Camino Graveyard :: OS Integration, enhancement)

Description

[Hiren Joshi]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050718 Camino/0.9a2
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050718 Camino/0.9a2

It would be useful to be able to search bookmarks based on keywords stored in
the description field for a bookmark. Currently, the Camino/Spotlight
integration does not populate the "Spotlight comment" field for the intermediate
files that mdimport actually indexes. Would it be possible to fill this comment
field in the generated fields to contain the text from the description field
stored in the Camino bookmark?

Reproducible: Always

Steps to Reproduce:
1. Add unique word in description of a Camino bookmark (e.g. foo in the bookmark
for http://bar.com)
2. Search for "foo" in spotlight

Actual Results:  
The bookmark does not appear in the Spotlight results.

Expected Results:  
The bookmark will be listed in the Spotlight results.

Comment 1

[Samuel Sidler (old account; do not CC)]

Mike, would you like to look at this for 1.1 or push it? You took it a while ago... :)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Mass-reassign of bugs still assigned to pinkerton to nobody; filter on "NoMoPinkBugsInCamino".

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

mento has code that could do this (see bug 154580 comment 60), though the general metadata writing code (and all its OS-and-SDK-checks) is in the nsDownloadListener.mm.  We could probably extract the general code-and-checks, or some of it, here or to a more general place and then hook it up to -writeBookmarksMetaDatatoPath:

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

This was fixed by Stuart's patch for bug 549179 (the description is an actual field in the metadata file, not shoehorned into the Finder comments).