306077 - do not package channel-prefs.js in MAR complete and partial patches

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Chase Phillips]

We need to ensure we're not packaging channel-prefs.js in MAR complete and
partial patches.  If we package it, then any changes to the build systems'
--enable-update-channel will be sent to nightly testers and then to beta users
when we switch back to the nightly channel for nightlies.

Comment 1

[Chase Phillips]

No, I misspoke.  It will not be sent to beta users because AUS2 will not be
sending them updates.  But packaging this file will inadvertently place nightly
users on the beta channel when we make the switch which we don't want to do.

Comment 2

[Chase Phillips]

From IRC, Ben and I discussed appending:

  ! -name "channel-prefs.js"

to the find commands at:
http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_full_update.sh#67
http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_incremental_update.sh#76
http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_incremental_update.sh#78

That should cause the channel-prefs.js file to be excluded from the list of
packaged files.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

I tested the find command in isolation with the modification chase mentions and
it seems to correctly exclude the specified file from the list. 

Comment 4

[Chase Phillips]

-> Darin

Comment 5

[Darin Fisher]

Attachment: v1 patch

Simple patch that excludes "channel-prefs.js" from the generated MAR files.

Comment 6

[Darin Fisher]

fixed-on-trunk, fixed1.8