do not package channel-prefs.js in MAR complete and partial patches

RESOLVED FIXED in mozilla1.8final

Status

()

Toolkit
Application Update
RESOLVED FIXED
13 years ago
10 years ago

People

(Reporter: Chase Phillips, Assigned: Darin Fisher)

Tracking

({fixed1.8})

unspecified
mozilla1.8final
x86
All
fixed1.8
Points:
---
Bug Flags:
blocking1.8b4 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: needs fix on branch and trunk)

Attachments

(1 attachment)

3.01 KB, patch
Chase Phillips
: review+
Chase Phillips
: approval1.8b4+
Details | Diff | Splinter Review
(Reporter)

Description

13 years ago
We need to ensure we're not packaging channel-prefs.js in MAR complete and
partial patches.  If we package it, then any changes to the build systems'
--enable-update-channel will be sent to nightly testers and then to beta users
when we switch back to the nightly channel for nightlies.
(Reporter)

Updated

13 years ago
Blocks: 305475
(Reporter)

Comment 1

13 years ago
No, I misspoke.  It will not be sent to beta users because AUS2 will not be
sending them updates.  But packaging this file will inadvertently place nightly
users on the beta channel when we make the switch which we don't want to do.
(Reporter)

Comment 2

13 years ago
From IRC, Ben and I discussed appending:

  ! -name "channel-prefs.js"

to the find commands at:
http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_full_update.sh#67
http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_incremental_update.sh#76
http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_incremental_update.sh#78

That should cause the channel-prefs.js file to be excluded from the list of
packaged files.
Flags: blocking1.8b4rc?
I tested the find command in isolation with the modification chase mentions and
it seems to correctly exclude the specified file from the list. 
(Reporter)

Comment 4

13 years ago
-> Darin
Assignee: nobody → darin
(Reporter)

Updated

13 years ago
Whiteboard: needs fix on branch and trunk
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox1.5

Updated

13 years ago
Flags: blocking1.8b4rc? → blocking1.8b4rc+
(Assignee)

Comment 5

13 years ago
Created attachment 194490 [details] [diff] [review]
v1 patch

Simple patch that excludes "channel-prefs.js" from the generated MAR files.
Attachment #194490 - Flags: review?(chase)
(Reporter)

Updated

13 years ago
Attachment #194490 - Flags: review?(chase)
Attachment #194490 - Flags: review+
Attachment #194490 - Flags: approval1.8b4+
(Assignee)

Comment 6

13 years ago
fixed-on-trunk, fixed1.8
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.