Closed
Bug 306077
Opened 19 years ago
Closed 19 years ago
do not package channel-prefs.js in MAR complete and partial patches
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: chase, Assigned: darin.moz)
References
Details
(Keywords: fixed1.8, Whiteboard: needs fix on branch and trunk)
Attachments
(1 file)
3.01 KB,
patch
|
chase
:
review+
chase
:
approval1.8b4+
|
Details | Diff | Splinter Review |
We need to ensure we're not packaging channel-prefs.js in MAR complete and partial patches. If we package it, then any changes to the build systems' --enable-update-channel will be sent to nightly testers and then to beta users when we switch back to the nightly channel for nightlies.
Reporter | ||
Comment 1•19 years ago
|
||
No, I misspoke. It will not be sent to beta users because AUS2 will not be sending them updates. But packaging this file will inadvertently place nightly users on the beta channel when we make the switch which we don't want to do.
Reporter | ||
Comment 2•19 years ago
|
||
From IRC, Ben and I discussed appending: ! -name "channel-prefs.js" to the find commands at: http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_full_update.sh#67 http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_incremental_update.sh#76 http://lxr.mozilla.org/mozilla/source/tools/update-packaging/make_incremental_update.sh#78 That should cause the channel-prefs.js file to be excluded from the list of packaged files.
Flags: blocking1.8b4rc?
Comment 3•19 years ago
|
||
I tested the find command in isolation with the modification chase mentions and it seems to correctly exclude the specified file from the list.
Reporter | ||
Updated•19 years ago
|
Whiteboard: needs fix on branch and trunk
Assignee | ||
Updated•19 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox1.5
Updated•19 years ago
|
Flags: blocking1.8b4rc? → blocking1.8b4rc+
Assignee | ||
Comment 5•19 years ago
|
||
Simple patch that excludes "channel-prefs.js" from the generated MAR files.
Attachment #194490 -
Flags: review?(chase)
Reporter | ||
Updated•19 years ago
|
Attachment #194490 -
Flags: review?(chase)
Attachment #194490 -
Flags: review+
Attachment #194490 -
Flags: approval1.8b4+
Assignee | ||
Comment 6•19 years ago
|
||
fixed-on-trunk, fixed1.8
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•