306087 - no Blizzard GTKWidget after building Minimo

Status: RESOLVED FIXED

(Minimo Graveyard :: Build Config, defect)

Description

[Antonio Gomes (tonikitoo)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

I am not able to build GTK widgets when I build MiniMo.

Reproducible: Always

Steps to Reproduce:
1. cd mozilla
2. cp minimo/config/mozconfig/linux_x86 mozconfig
3. make -f client.mk build_all

Actual Results:  
I got an error at compile time, and the compilatation fails. Something like:

make[4]: *** No rule to make target `../../../../dist/lib/libxulapp_s.a', needed
by `libgtkembedmoz.a'.  Stop.
make[4]: Leaving directory
`/home/agomes/MozillaDevel/dougt/mozilla/test-build/embedding/browser/gtk/src'
make[3]: *** [libs] Error 2
make[3]: Leaving directory
`/home/agomes/MozillaDevel/dougt/mozilla/test-build/embedding/minimo'
make[2]: *** [tier_99] Error 2
make[2]: Leaving directory `/home/agomes/MozillaDevel/dougt/mozilla/test-build'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/home/agomes/MozillaDevel/dougt/mozilla/test-build

Expected Results:  
I should be able to run TestGtkEmbed from mozilla/dist/bin directory ...

I will post the patch asap .

Comment 1

[Doug Turner (:dougt)]

great.

Comment 2

[Antonio Gomes (tonikitoo)]

Attachment: It probably solves the problem ...

Basicly, this patch makes some changes and correction on some Makefiles. For
applying it, try something like:

$ cd mozilla_topdir
$ patch -p0 < patch.diff

For testing it, 

$ rebuild your tree
(from the top level dir)
$ cd dist/bin
$ export LD_LIBRARY_PATH=.
$ ./minimo &
$ ./TestGtkEmbed &

enjoy it as you can.

Comment 3

[Doug Turner (:dougt)]

Attachment: Patch v.2

Comment 4

[Benjamin Smedberg]

Comment on attachment 193969 [details] [diff] [review]
Patch v.2

If it works, sure

Comment 5

[Doug Turner (:dougt)]

Checking in Makefile.in;
/cvsroot/mozilla/Makefile.in,v  <--  Makefile.in
new revision: 1.304; previous revision: 1.303
done
Checking in embedding/browser/gtk/src/Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/src/Makefile.in,v  <--  Makefile.in
new revision: 1.57; previous revision: 1.56
done
Checking in embedding/browser/gtk/tests/Makefile.in;
/cvsroot/mozilla/embedding/browser/gtk/tests/Makefile.in,v  <--  Makefile.in
new revision: 1.34; previous revision: 1.33
done
Checking in embedding/minimo/app/Makefile.in;
/cvsroot/mozilla/embedding/minimo/app/Makefile.in,v  <--  Makefile.in
new revision: 1.10; previous revision: 1.9
done
Checking in embedding/minimo/app/minimo-link-comps;
/cvsroot/mozilla/embedding/minimo/app/minimo-link-comps,v  <--  minimo-link-comps
new revision: 1.5; previous revision: 1.4
done

Thanks!