306132 - document the new shortcut for Bookmark All Tabs (Accel+Shift+D)

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[Steffen Wilberg]

This shortcut was introduced by bug 305955 on all platforms but Unix.

Comment 1

[Jeff Walden (gone starting June 8)]

"Add Bookmark" is in the Tools section.  Adding "Bookmark All Tabs" to the same
place is doable, but it conceivably works better in the "Windows and Tabs"
section.  I'm leaning toward renaming "Add Bookmark" to "Bookmark Current Page"
and adding "Bookmark All Tabs" to Tools, mainly because items in the W&T section
deal with opening, closing, and moving windows and tabs, not as much with tasks
which relate to them somewhat indirectly.  Steffen, what thoughts do you have on
placement here, and what do you suggest?

Comment 2

[Gabriel Sjoberg]

I think the way it is in HEAD is good.  "Bookmark This Page" is unambiguous, and
having the "Bookmark All Tabs" item directly below is intuitive.  I'm not sure
where the OP wants this to be documented, but the shortcut is listed directly
after the menu item in the bookmarks menu.

Comment 3

[Steffen Wilberg]

> I'm leaning toward renaming "Add Bookmark" to "Bookmark Current Page"
> and adding "Bookmark All Tabs" to Tools, mainly because items in the W&T section
> deal with opening, closing, and moving windows and tabs, not as much with tasks
> which relate to them somewhat indirectly.
Yeah, exactly. Plus we already have "Bookmarks" in Tools, plus the W&T section
is pretty long, whereas Tools is short.

Comment 4

[Gabriel Sjoberg]

(In reply to comment #2)
I'm retarded and didn't look at the component before opening my big
mouth...please disregard most of my comment.

However, I think that the labels for the shortcut in the documentation should
mirror the label that is in the menus to prevent any possible ambiguities and to
make internationalization easier.

Comment 5

[Jeff Walden (gone starting June 8)]

Attachment: Patch

Comment 6

[Steffen Wilberg]

Comment on attachment 194488 [details] [diff] [review]
Patch

Yeah, let's keep this in alphabetical order. "This" page? Hmm, I hope nobody
will assume that "This" refers to shortcuts.xhtml.
r=me with either "This" or "Current".

Comment 7

[Asa Dotzler [:asa]]

please post announcements to the l10n newsgroup when you check any of these
kinds of patches in. THanks.

Comment 8

[Jeff Walden (gone starting June 8)]

(In reply to comment #6)
> Yeah, let's keep this in alphabetical order. "This" page? Hmm, I hope nobody
> will assume that "This" refers to shortcuts.xhtml.

I thought about this but decided that either way is possible to misunderstand,
so I went with the one we already use.

(In reply to comment #7)
> please post announcements to the l10n newsgroup when you check any of these
> kinds of patches in. THanks.

Message posted, with a question about whether we should CC firefoxl10n at
hotmail dot com on such bugs as well.

Anyway, patch checked in on branch/trunk, marking FIXED...