306143 - GUI problem in 2005.08.26 nightly build [#ifdef -> %ifdef css preprocessor marker xul.css ]

Status: RESOLVED WORKSFORME

(Calendar :: Sunbird Only, defect)

Description

[石庭豐 (Seak, Teng-Fong)]

I was in another bug and have to try a nightly build and by chance found that
the 2005.08.26 nightly build has serious GUI problems.  If this is known and
supposed to be transient, feel free to mark this bug as resolved.

The following two images show the problems:
1) the calendar itself is not correctly drawn.  This is just aesthetical and not
a problem, but
2) when I tried to create a remote calendar, the location field isn't there!

Some other fields aren't of the correct size either but I didn't capture the images.

NB: The previous build, 2005.08.25 doesn't have this problem.

Comment 1

[石庭豐 (Seak, Teng-Fong)]

Attachment: Main calendar isn't drawn correctly

Comment 2

[石庭豐 (Seak, Teng-Fong)]

Attachment: Well, it's hard to enter the location ;-)

Comment 3

[gekacheka]

In the Javascript console I see

Error: Expected declaration but found '#ifdef'.  Skipped to next declaration.
Source File: chrome://global/content/xul.css
Line: 869

Error: Expected declaration but found '#endif'.  Skipped to next declaration.
Source File: chrome://global/content/xul.css
Line: 872

Looking in bonsai for files named xul.css, it looks like this regression caused
by Bug 305767 (changes preprocessor marker for .css files from # to %).  xul.css
was fixed recently by Bug 306061, changed #ifdef to %ifdef.
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/toolkit/content/xul.css

If this is the cause, this bug should be fixed in the next nightly.

Comment 4

[石庭豐 (Seak, Teng-Fong)]

Using the 20050827 build, and after having deleted the existing profile, I open
SB to find the following errors.

Error: subject.getBoolPref is not a function
Source File: chrome://calendar/content/pref/rootCalendarPref.js
Line: 99

Error: mozStorage exception: createStatement failed, statement: 'SELECT version
FROM cal_calendar_schema_version LIMIT 1', error: 'no such table:
cal_calendar_schema_version'
Source File: file:///C:/PROGRA~1/MOZILL~1.2_/components/calStorageCalendar.js
Line: 127

The calendar and other GUI components are indeed displayed correctly.
And then I added a remote calendar and removed the default one, I got the
following error:

Error: calendarManagerDNDObserver is not defined
Source File: chrome://calendar/content/calendar.xul
Line: 1

I think it's better to keep this bug open for at least one week because there's
always a chance of regression.

Comment 5

[Simon Paquet [:sipaq]]

Teng-Fong, these issues do not relate to the issue described in this bug. Please
file new bugs on these issues, if they do not already exist.

Comment 6

[石庭豐 (Seak, Teng-Fong)]

OK, but Resolution should have been FIXED rather than WORKSFORME, no?

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

No. There was no patch in this bug.
Yes. There was some patch that fixed this.

But who really cares? I do not. Let's just keep it worksforme.