306177 - Default plugin "Click to get the plugin" no longer works

Status: RESOLVED FIXED

(Camino Graveyard :: Plug-ins, defect, P2)

Description

[Simon Fraser [no longer active]]

When a plugin is missing, we show the default plugin, which displays "Click here
to get the plugin". If you click it, nothing happens.

I think the new plugin-related popup blocking stuff is breaking this. We
probably need to add some code to the default plugin to allow it to pop up a window.

This might also affect FF.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think this is Camino-only.  I don't have WMP installed, so this randomly
googled URL causes the default plugin to be displayed for me:

http://com2mac.postech.ac.kr/cgi-bin/print.cgi?soundbox=17&board=Com2MaC&Count=989675208&player=3

In DeerPark, clicking the plugin brings up a sheet that searches (and fails) to
find a plugin, as does clicking the "Install Missing Plugins…" button on the
evil page-overlay bar.

In Camino, I see a blocked popup notification on the status bar when the page
loads, and clicking the default plugin does nothing (but if the blocked popup
notification has disappeared from the status bar for some reason--not sure what
causes it--clicking on the default plugin causes the icon to re-appear on the
status bar).

Comment 2

[Simon Fraser [no longer active]]

Attachment: Patch

This patch adds calls to
NPN_PushPopupsEnabledState(true)/NPN_PopPopupsEnabledState() around the code
that the default plugin uses to open urls, and associated function pointer glue
code.

I also fixed PLUGINDEBUGSTR() to not cause so many warnings, and made the
Default Plugin XCode project use the 10.2 SDK.

Comment 3

[Mark Mentovai]

Comment on attachment 194071 [details] [diff] [review]
Patch

As discussed, there shouldn't be any SDK or DT settings in project files. 
They're communicated during a make, and will bust x86 compat.  ZERO_LINK=NO is
OK.

I needed to make a change to npapi.h in order to get this to compile.  r+ as
long as the change is included.

Comment 4

[Mark Mentovai]

Attachment: Required change, add missing characters to npapi.h

Looks like a typo.  lxr reveals that these are the only uses of these names in
the singular.

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 194194 [details] [diff] [review]
Required change, add missing characters to npapi.h

This patch was landed this morning via bug 176079.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 194071 [details] [diff] [review]
Patch

sr=jst

Comment 7

[Simon Fraser [no longer active]]

Comment on attachment 194071 [details] [diff] [review]
Patch

Checked into trunk. Camino 1.0 needs this, so requesting branch approval. Safe
change, only affects Mac default plugin.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 301052 has been marked as a duplicate of this bug. ***

Comment 9

[Simon Fraser [no longer active]]

Checked in on branch:
/cvsroot/mozilla/modules/plugin/samples/default/mac/NullPlugin.cpp,v  <-- 
NullPlugin.cpp
new revision: 1.11.28.1; previous revision: 1.11
done
Checking in npmac.cpp;
/cvsroot/mozilla/modules/plugin/samples/default/mac/npmac.cpp,v  <--  npmac.cpp
new revision: 1.6.76.1; previous revision: 1.6
done

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

what about the other copies of npmac.cpp, shouldn't they also be patched?

Comment 11

[Simon Fraser [no longer active]]

(In reply to comment #10)
> what about the other copies of npmac.cpp, shouldn't they also be patched?

Only if they want to use the popop methods; none of the npmac.cpp files has a
full table of function pointers.

Ideally we should have a canonical plugin example in an SDK, but don't.