306206 - add partial-patch target to tools/update-packaging/Makefile.in

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Chase Phillips]

A partial-patch target needs to be added to tools/update-packaging/Makefile.in.
 It should accept the following additional vars:

  $SRC_BUILD - a pathname referring to a directory containing a build we are 
               updating from

  $SRC_BUILD_ID - the build ID of the source build

  $DEST_BUILD - a pathname referring to a dir containing the build we are 
                updating to 

  $DEST_BUILD_ID - the build ID of the destination build

The output filename should be of the form:

  $(PKG_BASENAME).partial.$(SRC_BUILD_ID)-$(DEST_BUILD_ID).mar

While there, we will change the output filename of the complete patch to be:

  $(PKG_BASENAME).complete.mar

Comment 1

[Chase Phillips]

Attachment: add partial-patch target to tools/update-packaging/Makefile.in [checked in on trunk, not branch]

Comment 2

[Chase Phillips]

Comment on attachment 194073 [details] [diff] [review]
add partial-patch target to tools/update-packaging/Makefile.in [checked in on trunk, not branch]

Landing this on the trunk.  Branch landing will happen after it's had a chance
to bake.

Comment 3

[Chase Phillips]

Comment on attachment 194073 [details] [diff] [review]
add partial-patch target to tools/update-packaging/Makefile.in [checked in on trunk, not branch]

Checking in tools/update-packaging/Makefile.in;
/cvsroot/mozilla/tools/update-packaging/Makefile.in,v  <--  Makefile.in
new revision: 1.7; previous revision: 1.6
done

Comment 4

[Chase Phillips]

Fixed on trunk, not yet fixed on branch.

Comment 5

[Teemu Mannermaa (:wicked)]

Comment on attachment 194073 [details] [diff] [review]
add partial-patch target to tools/update-packaging/Makefile.in [checked in on trunk, not branch]

Would be nice to finally have this on the 1.8.1 branch.

Comment 6

[Mike Schroepfer]

Do we still want this on the branch?  If so what for?

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #6)
> Do we still want this on the branch?  If so what for?
> 

That patch is out of date (i.e. more changes have been made to that Makefile in other bugs) but it seems like a good idea to keep the trunk and branch files in sync. It's a useful target for XR apps to have.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 194073 [details] [diff] [review]
add partial-patch target to tools/update-packaging/Makefile.in [checked in on trunk, not branch]

Ben, then can you work up a new patch, get a r from preed and then renominate for branch?

Comment 9

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Updated 1.8 branch version

(In reply to comment #8)
> (From update of attachment 194073 [details] [diff] [review] [edit])
> Ben, then can you work up a new patch, get a r from preed and then renominate
> for branch?
> 

Here we go.

Comment 10

[J. Paul Reed [:preed]]

Comment on attachment 226842 [details] [diff] [review]
Updated 1.8 branch version

This is fine.

I actually think that those tools shouldn't be branched at all, unless they need to be.

It makes it a maintenance hassle to port fixes between the branches, and really, there's not any branch-specific stuff in the update packaging code (yet?)

I suppose, though, it's necessary because the build system uses these targets to build the complete patches... so... meh.

We still use the trunk revisions for all release-activities (because that's where we develop everything).

But cleanliness is good; thanks for doing this.

r=preed

Comment 11

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 226842 [details] [diff] [review]
Updated 1.8 branch version

Ok, beltzner. Back to you.

Comment 12

[Darin Fisher]

Comment on attachment 226842 [details] [diff] [review]
Updated 1.8 branch version

a=darin on behalf of drivers (please land on the MOZILLA_1_8_BRANCH and add the fixed1.8.1 keyword to the bug)

Comment 13

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on branch.