306207 - sendmail support under Windows bypasses message encoding

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Cédric Caron]

Sendmail support under windows (Bug 302418) bypass the e-mail encoding added 
by Bug 126266.

Comment 1

[:glob ✱]

Attachment: patch v1

*slaps head*

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 194147 [details] [diff] [review]
patch v1

I can't test this -- r=wurblzap provided you did and I understand correctly what you did.

Is this what you did?
1. You moved the encoding part up so that it happens before the Win-sendmail-specific part.
2. You're sending the encoded message to the Win-sendmail executable now instead of the unencoded one. You're sending it in two parts: header first, then body. The header is available by calling the as_string method of $headers, and the body immediately as $body.

Right?

Comment 3

[:glob ✱]

> tested ?

yes.  well, i think so.  it was a while ago :|

> 1. You moved the encoding part up so that it happens before the
> Win-sendmail-specific part.

yes.

> 2. You're sending the encoded message to the Win-sendmail executable now
> instead of the unencoded one. You're sending it in two parts: header first,
> then body. The header is available by calling the as_string method of
> $headers, and the body immediately as $body.

that's correct.

Comment 4

[Marc Schumann [:Wurblzap]]

Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.55; previous revision: 1.54
done

Comment 5

[Frédéric Buclin]

there is still a request for approval pending. reopening

Comment 6

[Frédéric Buclin]

err... sorry, the pending request was for blocking2.22, not for approval2.20 (I used to see "approval2.20" as a second flag :-[ )