306255 - [mac] The "Folder" button in the download manager isn't keyboard accessible (add support for toolbarbutton.tabbable in Pinstripe)

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect, P2)

Description

[Asaf Romano (gone)]

Since Pinstripe has no style rules for toolbarbutton.tabbable, the "Folder"
button in the download manager isn't keyboard accessible in the mac version.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Eek, outline seems to be buggy (part of it isn't drawn until the windows is
resized), so we'll have to use legacy border. This means the focus ring can
cause layout shrinks; however, it's almost invisible as a 1px only border.

At least until we can use outline, the focus ring itself has to be special
cased.

Comment 2

[Kevin Gerich]

Comment on attachment 194177 [details] [diff] [review]
patch

I haven't tested this, but I think you also need

#saveToFolder {
  border: 1px solid transparent;
}

so you avoid having the content jump around when you put the focus border on.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 194177 [details] [diff] [review]
patch

will do.

Comment 4

[Asaf Romano (gone)]

Attachment: patch for checkin

Comment 5

[Asaf Romano (gone)]

1.8 Branch:
Checking in pinstripe/global/toolbarbutton.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/toolbarbutton.css,v  <-- 
toolbarbutton.css
new revision: 1.4.10.1; previous revision: 1.4
done
Checking in pinstripe/mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloads.css,v  <--
 downloads.css
new revision: 1.7.2.2; previous revision: 1.7.2.1
done

Trunk:
Checking in global/toolbarbutton.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/toolbarbutton.css,v  <-- 
toolbarbutton.css
new revision: 1.5; previous revision: 1.4
done
Checking in mozapps/downloads/downloads.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/mozapps/downloads/downloads.css,v  <--
 downloads.css
new revision: 1.9; previous revision: 1.8
done

Trunk:

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381