306259 - Nits in nsPrintOptionsImpl

Status: RESOLVED FIXED

(Core :: Printing: Output, defect)

Description

[Bastiaan Jacques]

* Prefer construction over assignment.
* Make mDefaultFont a concrete type rather than a pointer.
* Use more nice macros.

Comment 1

[Bastiaan Jacques]

Attachment: patch v1

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 194113 [details] [diff] [review]
patch v1

sr=dmose

Comment 3

[Bastiaan Jacques]

Comment on attachment 194113 [details] [diff] [review]
patch v1

-  if (mIndex >= mCount) {
-    return NS_ERROR_UNEXPECTED;
-  }
+  NS_ENSURE_STATE(mIndex >= mCount);

Oops! This change is wrong..

Comment 4

[Bastiaan Jacques]

Attachment: patch v2

Let's try that again, shall we..

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 194220 [details] [diff] [review]
patch v2

sr=dmose

Comment 6

[Bastiaan Jacques]

Checked in by timeless (2005-09-02 02:04).