306271 - Group.pm needs a get_all_groups() routine

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

editgroups.cgi (for obvious reasons) as well as editflagtypes.cgi (to choose the
grant and request groups) require a list of groups available. I don't know yet
if a separate routine which returns non-system groups only would be useful. It
would be useful for editflagtypes.cgi, but I can live without it. ;)

I need it for bug 275608.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Frédéric Buclin]

(In reply to comment #0)
> if a separate routine which returns non-system groups only would be useful. It
> would be useful for editflagtypes.cgi, but I can live without it. ;)

err.. it's useless for editflagtypes.cgi, so such a routine which would return
only non-system groups is actually not required. So this patch is all what I
need. :)

Comment 3

[Joel Peshkin]

Comment on attachment 194128 [details] [diff] [review]
patch, v1

r=joel.
We'll have to change regexp to userregexp in the edit template interface later
if we decide to have edit use Group.pm as well.

Comment 4

[Frédéric Buclin]

Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.60; previous revision: 1.59
done
Checking in Bugzilla/Group.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Group.pm,v  <--  Group.pm
new revision: 1.8; previous revision: 1.7
done
Checking in template/en/default/admin/groups/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.2; previous revision: 1.1
done