306310 - empty tab shows garbage -- about:blank needs an encoding

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
1. Set your default encoding to UTF-16.
2. Open a new tab.

ACTUAL RESULTS
Garbage is displayed.

EXPECTED RESULTS
Nothing is displayed.

We are failing to auto-detect the encoding of about:blank (probably too little
data to go on or something) and falling back on the default encoding. We should
instead just be using the real encoding of about:blank, which is either US-ASCII
or a superset of US-ASCII such as UTF-8.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

this is an awesome bug.

Unfortunately, about:plugins and friends are harder to fix... they just
redirect to a chrome:// url, and I'm not sure all chrome channels should
specify a charset...

Comment 2

[Darin Fisher]

Comment on attachment 194184 [details] [diff] [review]
patch

Why not use utf-8 for about:blank as well?  I guess I'm worried about cases
where about:blank is loaded into a document and then mutated via the DOM (by
privileged script).

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

oh, I meant to change that to UTF-8. but DOM mutation should still be fine,
shouldn't it? that charset only affects parsing, not DOM mutation... (hm...
although it does affect the origin charset of URIs)

I'll change it to UTF-8

Comment 4

[Darin Fisher]

Comment on attachment 194184 [details] [diff] [review]
patch

good point about DOM mutations... also, we now ignore the origin charset when
encoding URIs ;-)  we default to always encoding using UTF-8 for Firefox 1.5
;-)

Comment 5

[Darin Fisher]

that's r+sr=darin with the change from us-ascii to utf-8 anyways for good measure.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: utf-8 even for about:blank

don't we still use the origin charset for unescaping the URI for UI, or
something like that?

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed on trunk
Checking in netwerk/protocol/about/src/nsAboutBlank.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutBlank.cpp,v  <-- 
nsAboutBlank.cpp
new revision: 1.31; previous revision: 1.30
done
Checking in netwerk/protocol/about/src/nsAboutBloat.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutBloat.cpp,v  <-- 
nsAboutBloat.cpp
new revision: 1.39; previous revision: 1.38
done
Checking in netwerk/protocol/about/src/nsAboutCache.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutCache.cpp,v  <-- 
nsAboutCache.cpp
new revision: 1.40; previous revision: 1.39
done
Checking in netwerk/protocol/about/src/nsAboutCacheEntry.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutCacheEntry.cpp,v  <-- 
nsAboutCacheEntry.cpp
new revision: 1.29; previous revision: 1.28
done

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 194433 [details] [diff] [review]
utf-8 even for about:blank

transferring r+sr=darin

low risk patch to make various about: pages work with unusual default charset
prefs

Comment 9

[Darin Fisher]

> don't we still use the origin charset for unescaping the URI for UI, or
> something like that?

Yeah, that does happen in some cases.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

MOZILLA_1_8_BRANCH:
Checking in netwerk/protocol/about/src/nsAboutBlank.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutBlank.cpp,v  <-- 
nsAboutBlank.cpp
new revision: 1.30.20.1; previous revision: 1.30
done
Checking in netwerk/protocol/about/src/nsAboutBloat.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutBloat.cpp,v  <-- 
nsAboutBloat.cpp
new revision: 1.38.18.1; previous revision: 1.38
done
Checking in netwerk/protocol/about/src/nsAboutCache.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutCache.cpp,v  <-- 
nsAboutCache.cpp
new revision: 1.39.12.1; previous revision: 1.39
done
Checking in netwerk/protocol/about/src/nsAboutCacheEntry.cpp;
/cvsroot/mozilla/netwerk/protocol/about/src/nsAboutCacheEntry.cpp,v  <-- 
nsAboutCacheEntry.cpp
new revision: 1.28.12.1; previous revision: 1.28
done