306325 - Move CanEnterProduct() and CanEnterProductOrWarn() out of globals.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

These routines are user-specific and should go into User.pm; for instance:
$user->can_enter_product($product_name).

Comment 1

[Frédéric Buclin]

Also include GetEnterableProducts() as it depends on CanEnterProduct(). I will
wait for bug 286158 to be checked in before moving these routines.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Joel Peshkin]

Comment on attachment 194970 [details] [diff] [review]
patch, v1

The new can_enter_product ignores ENTRY from group_control_map.

Comment 4

[Frédéric Buclin]

Attachment: patch, v2

Comment 5

[Joel Peshkin]

Comment on attachment 197432 [details] [diff] [review]
patch, v2

r=joel, but I want a 2xr on this and someone to run some serious QA tests on
it.

Comment 6

[Frédéric Buclin]

Comment on attachment 197432 [details] [diff] [review]
patch, v2

wicked or mkanat, could you have a look at it?

Comment 7

[Max Kanat-Alexander]

Comment on attachment 197432 [details] [diff] [review]
patch, v2

I nominate wicked. :-)

Comment 8

[Teemu Mannermaa (:wicked)]

Comment on attachment 197432 [details] [diff] [review]
patch, v2

>Index: Bugzilla/User.pm
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v
>+    if (!defined($product_name)) {
>+        return unless $warn;

Nit: I'd rather see this explicitly return 0 instead of undef/empty
list/nothing depending on context.

>+    if (!$has_access) {
>+        return unless $warn;

Nit: Ditto.

>+ Description: Returns 1 if the user can enter bugs into the specified product.
..
>+              - if $warn is false (or not given), a 'false' value is returned;

Nit: Please be consistent, either 0/1 or false/true but not mixed like this.
Probably best to use 0 and 1 everywhere.

>+ Params:      $product_name - a product name.
>+              $warn         - optional parameter, indicating whether an error
>+                              must be thrown if the user cannot enter bugs
>+                              into the specified product.

Nit: Document also what values are needed to trigger which behaviour of $warn.

>+ Returns:     1 if the user can enter bugs into the product,
>+              0 if the user cannot enter bugs into the product and if $warn
>+              is false (an error is thrown if $warn is true).

Nit: Can also return undef when user can't enter bugs into product because it
has no components.

Comment 9

[Joel Peshkin]

Lpsolit:
  You'll need to make one further update to enter_bug.cgi that is not in your
current patch as a result of bug 311489.

Comment 10

[Frédéric Buclin]

Attachment: patch, v2.5

updated patch to take joel's patch into account (in enter_bug.cgi).

Comment 11

[Frédéric Buclin]

Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v <--  buglist.cgi
new revision: 1.313; previous revision: 1.312
done
Checking in describecomponents.cgi;
/cvsroot/mozilla/webtools/bugzilla/describecomponents.cgi,v
<--  describecomponents.cgi
new revision: 1.31; previous revision: 1.30
done
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.122; previous revision: 1.121
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.342; previous revision: 1.341
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.127; previous revision: 1.126
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.287; previous revision: 1.286
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.97; previous revision: 1.96
done
Checking in Bugzilla/User.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v  <--  User.pm
new revision: 1.87; previous revision: 1.86
done
Checking in template/en/default/list/edit-multiple.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/list/edit-multiple.html.tmpl,v
 <--  edit-multiple.html.tmpl
new revision: 1.31; previous revision: 1.30
done