Closed Bug 306330 Opened 15 years ago Closed 13 years ago

Search engines which don't have an icon have less margin than the others

Categories

(Firefox :: Search, defect, P4, trivial)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 alpha2

People

(Reporter: adelfino, Assigned: Gavin)

References

Details

(Keywords: regression, verified1.8.1.8)

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050828 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050828 Firefox/1.0+

You can see an screenshot here:

http://img4.imageshack.us/img4/8973/bug2fx.png

Reproducible: Always

Steps to Reproduce:
1. Install a search engine with an icon
2. Install a search engine without an icon
3. Open the search engines menu
Actual Results:  
The search engine without icon has less margin than the other

Expected Results:  
Both engines should have the same margin
Version: unspecified → 1.5 Branch
This is a regression from bug 253661. I remember Bryan talking about this, but
it must have slipped through the cracks.
Severity: trivial → minor
Status: UNCONFIRMED → NEW
Depends on: 253661
Ever confirmed: true
Keywords: regression
Version: 1.5 Branch → Trunk
Simple fix.  The icons just need 16px x 16px dimensions defined.
		
.menu-iconic-icon {
  /* sets icons in menus to 16px */
   max-width: 16px;
   max-height: 16px;
}

Either in global/menu.css for all menu icons (not sure without testing if
that'll screw with other stuff), or with a more specific selector in
browser/browser.css to only target the search icons.

I guess i never had search engines without icons (or didn't know there were any
without them), so didn't realize to test for this with that original menus patch.
I already have a fix for this that takes into account the issue of search
engines NOT including an image!  Patch forthcoming shortly...

~B
Bryan, do you have the patch for this?
Will this be fixed for Mozilla Firefox 1.5? :S
Severity: minor → normal
Severity: normal → trivial
OS: Windows XP → All
Hardware: PC → All
Attached patch patchSplinter Review
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #246114 - Flags: review?(mano)
Priority: -- → P4
Target Milestone: --- → Firefox 3 alpha2
Whiteboard: [patch-r?]
Whiteboard: [patch-r?] → [checkin needed]
mozilla/browser/themes/winstripe/browser/browser.css 	1.49
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Depends on: 361769
Fixed on the branch for 2.0.0.7 by the branch patch for bug 363130.
Keywords: fixed1.8.1.7
verified fixed 1.8.1.7 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.7pre) Gecko/2007091204 BonEcho/2.0.0.7pre

looks okay now and verified after tests with several search engines -> adding verified keyword
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.