306330 - Search engines which don't have an icon have less margin than the others

Status: VERIFIED FIXED

(Firefox :: Search, defect, P4)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050828 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050828 Firefox/1.0+

You can see an screenshot here:

http://img4.imageshack.us/img4/8973/bug2fx.png

Reproducible: Always

Steps to Reproduce:
1. Install a search engine with an icon
2. Install a search engine without an icon
3. Open the search engines menu
Actual Results:  
The search engine without icon has less margin than the other

Expected Results:  
Both engines should have the same margin

Comment 1

[Adam Guthrie]

This is a regression from bug 253661. I remember Bryan talking about this, but
it must have slipped through the cracks.

Comment 2

[miahz]

Simple fix.  The icons just need 16px x 16px dimensions defined.
		
.menu-iconic-icon {
  /* sets icons in menus to 16px */
   max-width: 16px;
   max-height: 16px;
}

Either in global/menu.css for all menu icons (not sure without testing if
that'll screw with other stuff), or with a more specific selector in
browser/browser.css to only target the search icons.

I guess i never had search engines without icons (or didn't know there were any
without them), so didn't realize to test for this with that original menus patch.

Comment 3

[Bryan]

I already have a fix for this that takes into account the issue of search
engines NOT including an image!  Patch forthcoming shortly...

~B

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Bryan, do you have the patch for this?

Comment 5

[Andrés Delfino]

Will this be fixed for Mozilla Firefox 1.5? :S

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 7

[Asaf Romano (gone)]

Comment on attachment 246114 [details] [diff] [review]
patch

r=mano

Comment 8

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/themes/winstripe/browser/browser.css 	1.49

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Fixed on the branch for 2.0.0.7 by the branch patch for bug 363130.

Comment 10

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.7 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.7pre) Gecko/2007091204 BonEcho/2.0.0.7pre

looks okay now and verified after tests with several search engines -> adding verified keyword