User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6 Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6 If you use too many file filters, you can crash and burn. patch that fixes the crash to be attached... Reproducible: Always Steps to Reproduce:
Component: General → XP Toolkit/Widgets
Product: Firefox → Core
Version: unspecified → 1.8 Branch
ccing a bunch of mac folks
Assignee: nobody → joshmoz
Component: XP Toolkit/Widgets → Widget: Mac
QA Contact: general → mac
Comment on attachment 194207 [details] [diff] [review] fix for crash in nsFilePicker.cpp Looks good. Thanks for the patch! We may want to consider some kind of warning to the console if you use too many filters, since it seems some are going to get ignored silently.
Attachment #194207 - Flags: review+
Assignee: joshmoz → shanec
This is a very safe patch, and should go in on the branch.
Attachment #194207 - Flags: approval1.8b4? → approval1.8b4+
checked in on trunk and 1.8 branch
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Keywords: fixed1.8 → verified1.8
You need to log in before you can comment on or make changes to this bug.