306355 - Don't put important configuration in mail/config/mozconfig

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P3)

Description

[Benjamin Smedberg]

All the important config options should be coded into configure, leaving the
mail/config/mozconfig with only --enable-application and MOZ_CO_PROJECT. This
makes maintenance much easier.

Comment 1

[Benjamin Smedberg]

Attachment: Move defaults from mail/config/mozconfig to configure.in

Comment 2

[Benjamin Smedberg]

I'd like to get this on the 1.8 branch so that tbird matches the other apps.

Comment 3

[Scott MacGregor]

Comment on attachment 194210 [details] [diff] [review]
Move defaults from mail/config/mozconfig to configure.in

Let's make sure we get a day's worth of nightly builds on the trunk with this
change so we can be sure we didn't miss anything before we put it on the
branch. The disk size should be able to tell.

Comment 4

[Scott MacGregor]

My build is now trying to build 

Leaving directory
`/cygdrive/c/build/trees/tbirddbg/mozilla/embedding/browser/activex

which was not the case before this change. 

So something didn't get mapped over quite right on the trunk.

Comment 5

[Scott MacGregor]

Comment on attachment 194210 [details] [diff] [review]
Move defaults from mail/config/mozconfig to configure.in

minusing for the branch for right now as this doesn't appear to be working
quite right.

Comment 6

[Benjamin Smedberg]

Attachment: Move activex defaults where they belong, before app-specific overrides

Comment 7

[Scott MacGregor]

Comment on attachment 194210 [details] [diff] [review]
Move defaults from mail/config/mozconfig to configure.in

this needs plussed too since we already plussed the follow up patch.

Comment 8

[Asa Dotzler [:asa]]

Time is short for 1.8b4. If this isn't landed today, it's not going to make the
train.

Comment 9

[Scott MacGregor]

this patch needs to wait for the tree to re-open for 1.8b5 now. 

Comment 10

[Benjamin Smedberg]

Fixed on branch as well.