Closed Bug 306363 Opened 19 years ago Closed 19 years ago

Clean up nsContentUtils service getters

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: peterv, Assigned: peterv)

References

Details

Attachments

(1 file, 2 obsolete files)

 
Attached patch v1 (obsolete) — Splinter Review
Attached patch v1 (diff -w) (obsolete) — Splinter Review
Attachment #194228 - Flags: superreview?(bzbarsky)
Attachment #194228 - Flags: review?(bzbarsky)
Comment on attachment 194228 [details] [diff] [review]
v1 (diff -w)

>Index: content/base/src/nsContentUtils.cpp

>   rv = CallGetService(kJSStackContractID, &sThreadJSContextStack);
>+  NS_ENSURE_SUCCESS(rv, rv);

There are a few places in this file that null-check sThreadJSContextStack. 
Want to remove those checks?

r+sr=bzbarsky with that.
Attached patch v1Splinter Review
Removed sThreadJSContextStack null-checks. Marking bz's r/sr.
Attachment #194222 - Attachment is obsolete: true
Attachment #194228 - Attachment is obsolete: true
Attachment #195439 - Flags: superreview+
Attachment #195439 - Flags: review+
Attachment #194228 - Flags: superreview?(bzbarsky)
Attachment #194228 - Flags: review?(bzbarsky)
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9alpha
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: