306382 - Components.utils.evalInSandbox can fail silently

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Blake Kaplan (:mrbkap) (inactive)]

When the fix for bug 303108 went in, I made the bad assumption that
JS_EvaluateUCScriptForPrincipals would always have a pending exception. This
isn't the case for OOM, where the function returns false, but doesn't set a
pending exception. In this case, evalInSandbox should still signal the error,
and not simply return NS_OK.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: catch OOM

Brendan tells me that OOM is the only time when this happens, so I went with
the more specific return value.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 194248 [details] [diff] [review]
catch OOM

This is the wrong diff.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: correct diff

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

This should probably block 1.8b4 since it's a new API and all that. This is also
an ultra-simple fix.

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 194250 [details] [diff] [review]
correct diff

Yeah, we need to fix this last detail.

/be

Comment 6

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 194250 [details] [diff] [review]
correct diff

r=shaver

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into MOZILLA_1_8_BRANCH and trunk.

Comment 8

[Darin Fisher]

There's a report about PAC being broken in the builds after this patch landed. 
Could this have regressed PAC?  Please see bug 306467.  Thanks!