306431 - Confusing/misplaced sentence in Privacy section of Help

Status: RESOLVED FIXED

(Firefox Graveyard :: Help Documentation, defect)

Description

[PikeUK]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050830
Firefox/1.6a1

The sentence below appears to be misplaced or missing a heading or something. It
is "placed" in the "Clear Private Data Settings" section, but it actually refers
to the whole Privacy section:

"To display section-specific options, display a section by clicking on its tab."

Comment 1

[Steffen Wilberg]

Indeed. What would you suggest? We could move "Clear Private Data Settings" down
after the Cache section, but then it's related to the Clear buttons described at
the top of the Privacy section.

Do we need that sentence at all?

Comment 2

[PikeUK]

The sentence does seem redundant, if the reader knows what a tab is then it's
unnecessary, if they don't know what a tab is then it doesn't help.

One thing I forgot to mention is that "Clear Private Data" is shown below
"Cache" in the TOC but on the actual page it's positioned above "History". So
I'd probably remove the sentence AND relocate "Clear Private Data" to just below
the "Cache" section.

Comment 3

[Steffen Wilberg]

Attachment: remove that sentence and move 'clear private data' up in the toc

That sentence is indeed redundant.

I like the position of Clear Private Data Settings because it's related to the Clear buttons described at the top of the Privacy section, so I changed the toc to match that order.

Comment 4

[Steffen Wilberg]

Checked into trunk.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 205425 [details] [diff] [review]
remove that sentence and move 'clear private data' up in the toc

Not taking localization-hits for 1.8.0.1, a-

Comment 6

[Steffen Wilberg]

1.8 branch:
Checking in mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/firebird-toc.rdf,v  <--  firebird-toc.rdf
new revision: 1.34.2.9; previous revision: 1.34.2.8
done
Checking in mozilla/browser/locales/en-US/chrome/help/prefs.xhtml;
/cvsroot/mozilla/browser/locales/en-US/chrome/help/prefs.xhtml,v  <--  prefs.xhtml
new revision: 1.34.2.9; previous revision: 1.34.2.8
done