306434 - Home page text field in Firefox's Preferences has a 2px/4px white border

Status: RESOLVED DUPLICATE of bug 284808

(Firefox :: Settings UI, defect)

Description

[Marek Stępień [:marcoos, inactive]]

Under Linux, the homepage field in the General tab of the Preferences window has
a 2px/4px white border around it, making that field look awkward and not obey
the GTK theme. This is especially visible with GTK themes like Clearlooks (Gnome
2.10 default) and Gorilla.

Thunderbird has a similar field in its Preferences, but there it looks as it
should do.

A screenshot comparing Firefox and Thunderbird (default Fx/Tb themes, Clearlooks
theme in GTK) follows.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: Screenshot showing Firefox (wrong) and Thunderbird (correct)

Actually, the screenshot shows GTK's Gorilla theme, not Clearlooks, but the
problem is the same.

Comment 2

[Peter van der Woude [:Peter6]]

a build id / useragent string would be usefull

Comment 3

[Marek Stępień [:marcoos, inactive]]

This is caused by the following entry in
/browser/themes/winstripe/browser/preferences/preferences.css:

/* General Pane */
#browserStartupHomepage {
  padding-top: 2px;
  padding-bottom: 3px;
  -moz-padding-start: 4px;
  -moz-padding-end: 2px;
}

<http://lxr.mozilla.org/mozilla1.8/source/browser/themes/winstripe/browser/preferences/preferences.css#87>

I think it should be removed or made Windows-only (if it had a purpose under
Windows).

Comment 4

[Marek Stępień [:marcoos, inactive]]

(In reply to comment #2)
> a build id / useragent string would be usefull

Any recent GTK 2 build of Firefox, both branch&trunk.

Such as yesterday's mozilla.org en-US nightly build:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b4) Gecko/20050829 Firefox/1.0+

Comment 5

[Vidar Haarr (not reading bugmail)]

Attachment: makes it look alright in gnome, at least.

This patch makes it look alright in GNOME. I have no idea how it will look on
Windows or other platforms.

Comment 6

[Adam Guthrie]

Comment on attachment 195687 [details] [diff] [review]
makes it look alright in gnome, at least.

Please do not request approval on patches prior to getting them revied.

Comment 7

[Adam Guthrie]

Comment on attachment 195687 [details] [diff] [review]
makes it look alright in gnome, at least.

Please do not request approval on patches prior to getting them revied.

Comment 8

[Markus Lindström]

*** This bug has been marked as a duplicate of 284808 ***