Closed
Bug 306463
Opened 19 years ago
Closed 19 years ago
make an 'unwrap_full_update.sh' script to unmar and unbzip2 a complete patch .mar file
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: chase, Assigned: chase)
Details
Attachments
(1 file)
|
1.65 KB,
patch
|
chase
:
review+
|
Details | Diff | Splinter Review |
Let's make an unwrap_full_update.sh script in tools/update-packaging that will unmar and unbzip2 a .mar (reversing the process that make_full_update.sh) does. This will make creating partial patches easier since they are based on complete patches.
| Assignee | ||
Updated•19 years ago
|
Summary: make a 'unwrap_full_update.sh' script to unmar and unbzip2 a .mar file → make an 'unwrap_full_update.sh' script to unmar and unbzip2 a complete patch .mar file
| Assignee | ||
Comment 2•19 years ago
|
||
Comment on attachment 194363 [details] [diff] [review] v1 patch [checked in] This is a great first cut. Can you land it on the trunk so I can use it in my patch packaging system? The only piece not in this version is the optional specification of a directory into which the mar would be extracted. But that can be handled in other ways and it's not a good reason to hold from getting this in.
Attachment #194363 -
Flags: review?(chase) → review+
| Assignee | ||
Comment 3•19 years ago
|
||
Comment on attachment 194363 [details] [diff] [review] v1 patch [checked in] Darin, I checked this in on the trunk on your behalf so I could get unblocked for creating partial patches. I hope that's okay. Thanks again for the patch. RCS file: /cvsroot/mozilla/tools/update-packaging/unwrap_full_update.sh,v done Checking in unwrap_full_update.sh; /cvsroot/mozilla/tools/update-packaging/unwrap_full_update.sh,v <-- unwrap_full_update.sh initial revision: 1.1 done
| Assignee | ||
Updated•19 years ago
|
Assignee: nobody → chase
| Assignee | ||
Updated•19 years ago
|
Attachment #194363 -
Attachment description: v1 patch → v1 patch [checked in]
| Assignee | ||
Updated•19 years ago
|
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment 4•19 years ago
|
||
OK, thanks chase. I imagined using the -C argument to the mar executable to specify where to extract the MAR file. I may do that as a follow-up patch.
| Assignee | ||
Comment 5•19 years ago
|
||
(In reply to comment #4) > OK, thanks chase. I imagined using the -C argument to the mar executable to > specify where to extract the MAR file. I may do that as a follow-up patch. Oddest thing.. I couldn't get -C to work for me locally so I've just been altering my working directory before calling mar. I seem to recall having a similar problem a ways back but don't have any data points on that. I wish I could give you more info but that's all I've got atm.
Comment 6•19 years ago
|
||
Yeah, it turns out that -C won't work with extraction unless the path to the archive file is absolute. I need to fix the mar executable so that the -C argument can be used even when the MAR file is specified using a relative path.
| Assignee | ||
Comment 7•19 years ago
|
||
(In reply to comment #6) > Yeah, it turns out that -C won't work with extraction unless the path to the > archive file is absolute. I need to fix the mar executable so that the -C > argument can be used even when the MAR file is specified using a relative path. Aha! Gotcha. unwrap_full_update.sh works well enough that my partial patch sizes make sense now. Good times.
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•