306520 - Closing Find Bar should properly restore focus if it didn't change

Status: NEW

(Toolkit :: Find Toolbar, enhancement, P3)

Description

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20050830 Firefox/1.6a1
ID:2005083010

When you are typing in a form, or <input>, etc. and hit Ctrl+F to bring up FAYT,
when you close FAYT focus (the cursor) is not returned to that element. The
element is focused (with respect to the tab index) but you can't resume typing
in it.

1. Focus cursor in input.
2. Ctrl+F to bring up FAYT.
3. ESC or press the close button.

The cursor is not brought back to focus in the form element.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

taking.

Comment 2

[Adam Guthrie]

So, there are cases where this behavior makes sense and some where it doesn't. The cases where I think we should be doing this are when:

* the user invokes find and immediately dismisses it or
* the user invokes find and types in a search term that's not found.

In other cases, a link will have focus or the search term will be selected. I don't think we want to kill that selection or focus on the link! Thoughts?

Comment 3

[Peter Kasting]

I can further refine comment 2 to note that the user would have to type in a search term where _not even one character is found_.  If anything at all is found, the bar will change "focus" (well, its faked up version of focus), and I don't think we can blow that away when the bar is dismissed.

It's hard to convert that into a short summary, but I gave it a shot.

Comment 4

[Asaf Romano (gone)]

Attachment: v1

Comment 5

[Hideo Oshima]

I think this is fixed with latest trunk build.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090701 Minefield/3.6a1pre

Comment 6

[baffclan]

Cannot reproduce with Nightly(20160409030219)/Windows7(x64)