Closed Bug 306550 Opened 16 years ago Closed 16 years ago

gtkmozembed progress flags lack STATE_RESTORING value

Categories

(Core Graveyard :: Embedding: GTK Widget, defect)

x86
Linux
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chpe, Assigned: chpe)

Details

(Keywords: fixed1.8)

Attachments

(1 file)

The fastback changes in bug 292971 added STATE_RESTORING to
nsIWebProgressListener's state flags; but gtkmozembed's GtkMozEmbedProgressFlags
enum wasn't updated.
Attached patch fixSplinter Review
Assignee: mpgritti → chpe
Status: NEW → ASSIGNED
Attachment #194427 - Flags: superreview?(roc)
Attachment #194427 - Flags: review?(mpgritti)
Comment on attachment 194427 [details] [diff] [review]
fix

-  GTK_MOZ_EMBED_FLAG_IS_WINDOW = 524288 
+  GTK_MOZ_EMBED_FLAG_IS_WINDOW = 524288,
+  GTK_MOZ_EMBED_FLAG_RESTORING = 16777216

Since RESTORING is a separate group please put a new line between it and 
IS_WINDOW...
Attachment #194427 - Flags: review?(mpgritti) → review+
Comment on attachment 194427 [details] [diff] [review]
fix

only affects GTK embedding
Attachment #194427 - Flags: superreview?(roc)
Attachment #194427 - Flags: superreview+
Attachment #194427 - Flags: approval1.8b5?
Attachment #194427 - Flags: approval1.8b5? → approval1.8b5+
checked in with the whitespace change made

trunk:
Checking in embedding/browser/gtk/src/gtkmozembed.h;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed.h,v  <--  gtkmozembed.h
new revision: 1.35; previous revision: 1.34
done
Checking in embedding/browser/gtk/src/gtkmozembed2.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed2.cpp,v  <--  gtkmozembed2.cpp
new revision: 1.47; previous revision: 1.46
done

MOZILLA_1_8_BRANCH:
Checking in embedding/browser/gtk/src/gtkmozembed.h;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed.h,v  <--  gtkmozembed.h
new revision: 1.34.12.1; previous revision: 1.34
done
Checking in embedding/browser/gtk/src/gtkmozembed2.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed2.cpp,v  <--  gtkmozembed2.cpp
new revision: 1.43.8.4; previous revision: 1.43.8.3
done
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.