Last Comment Bug 306550 - gtkmozembed progress flags lack STATE_RESTORING value
: gtkmozembed progress flags lack STATE_RESTORING value
Status: RESOLVED FIXED
: fixed1.8
Product: Core Graveyard
Classification: Graveyard
Component: Embedding: GTK Widget (show other bugs)
: Trunk
: x86 Linux
: -- major (vote)
: ---
Assigned To: Christian Persch (GNOME) (away; not receiving bug mail)
: Stuart Parmenter
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-31 03:53 PDT by Christian Persch (GNOME) (away; not receiving bug mail)
Modified: 2012-04-05 00:46 PDT (History)
1 user (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
fix (2.29 KB, patch)
2005-08-31 03:53 PDT, Christian Persch (GNOME) (away; not receiving bug mail)
mpgritti: review+
roc: superreview+
asa: approval1.8b5+
Details | Diff | Splinter Review

Description Christian Persch (GNOME) (away; not receiving bug mail) 2005-08-31 03:53:13 PDT
The fastback changes in bug 292971 added STATE_RESTORING to
nsIWebProgressListener's state flags; but gtkmozembed's GtkMozEmbedProgressFlags
enum wasn't updated.
Comment 1 Christian Persch (GNOME) (away; not receiving bug mail) 2005-08-31 03:53:46 PDT
Created attachment 194427 [details] [diff] [review]
fix
Comment 2 Marco Pesenti Gritti 2005-08-31 04:22:41 PDT
Comment on attachment 194427 [details] [diff] [review]
fix

-  GTK_MOZ_EMBED_FLAG_IS_WINDOW = 524288 
+  GTK_MOZ_EMBED_FLAG_IS_WINDOW = 524288,
+  GTK_MOZ_EMBED_FLAG_RESTORING = 16777216

Since RESTORING is a separate group please put a new line between it and 
IS_WINDOW...
Comment 3 Robert O'Callahan (:roc) (email my personal email if necessary) 2005-09-15 18:05:44 PDT
Comment on attachment 194427 [details] [diff] [review]
fix

only affects GTK embedding
Comment 4 Christian :Biesinger (don't email me, ping me on IRC) 2005-09-18 07:07:10 PDT
checked in with the whitespace change made

trunk:
Checking in embedding/browser/gtk/src/gtkmozembed.h;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed.h,v  <--  gtkmozembed.h
new revision: 1.35; previous revision: 1.34
done
Checking in embedding/browser/gtk/src/gtkmozembed2.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed2.cpp,v  <--  gtkmozembed2.cpp
new revision: 1.47; previous revision: 1.46
done

MOZILLA_1_8_BRANCH:
Checking in embedding/browser/gtk/src/gtkmozembed.h;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed.h,v  <--  gtkmozembed.h
new revision: 1.34.12.1; previous revision: 1.34
done
Checking in embedding/browser/gtk/src/gtkmozembed2.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed2.cpp,v  <--  gtkmozembed2.cpp
new revision: 1.43.8.4; previous revision: 1.43.8.3
done

Note You need to log in before you can comment on or make changes to this bug.