306550 - gtkmozembed progress flags lack STATE_RESTORING value

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

The fastback changes in bug 292971 added STATE_RESTORING to
nsIWebProgressListener's state flags; but gtkmozembed's GtkMozEmbedProgressFlags
enum wasn't updated.

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: fix

Comment 2

[Marco Pesenti Gritti]

Comment on attachment 194427 [details] [diff] [review]
fix

-  GTK_MOZ_EMBED_FLAG_IS_WINDOW = 524288 
+  GTK_MOZ_EMBED_FLAG_IS_WINDOW = 524288,
+  GTK_MOZ_EMBED_FLAG_RESTORING = 16777216

Since RESTORING is a separate group please put a new line between it and 
IS_WINDOW...

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 194427 [details] [diff] [review]
fix

only affects GTK embedding

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in with the whitespace change made

trunk:
Checking in embedding/browser/gtk/src/gtkmozembed.h;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed.h,v  <--  gtkmozembed.h
new revision: 1.35; previous revision: 1.34
done
Checking in embedding/browser/gtk/src/gtkmozembed2.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed2.cpp,v  <--  gtkmozembed2.cpp
new revision: 1.47; previous revision: 1.46
done

MOZILLA_1_8_BRANCH:
Checking in embedding/browser/gtk/src/gtkmozembed.h;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed.h,v  <--  gtkmozembed.h
new revision: 1.34.12.1; previous revision: 1.34
done
Checking in embedding/browser/gtk/src/gtkmozembed2.cpp;
/cvsroot/mozilla/embedding/browser/gtk/src/gtkmozembed2.cpp,v  <--  gtkmozembed2.cpp
new revision: 1.43.8.4; previous revision: 1.43.8.3
done