306565 - [adblock] ad blocking blocks images on yahoo weather

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Mike Pinkerton (not reading bugmail)]

go to http://weather.yahoo.com/forecast/USVA0735_f.html

with adblock on, the weekly forecast images don't display. turn adblock off and
reload the page, they appear.

2005083004, branch.

Comment 1

[Simon Fraser [no longer active]]

The images are on yimg.com, and I blocked that whole domain  :)

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

*** Bug 306532 has been marked as a duplicate of this bug. ***

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I just duped widgets.yahoo.com here, since it's the same issue.  IIRC there are
certain directories/paths/subdomains on yimg.com that contain their ads and the
rest of the domain contains more-or-less valid images.

I had these rules in my old userContent.css (some rules of my own making and
some from stock sheets):
*[src*=".a.yimg.com/"],
*[src*=".a1.yimg.com/"],
*[src*="/us.yimg.com/a/ya"],
*[src*="us.eb1.yimg.com"],	/* trying to wack Yahoo right column ads */
*[href*="us.ard.yahoo.com"] img,

div#mntl, div#quack, div[id*="sponsor"],            /* yahoo, general */

form[action^="http://us.ard.yahoo.com"],            /* forms - mostly yahoo */
a[href*="www10.overture.com"]


No guarantees that there won't still be some false positives (div id*="sponsor"
could be pretty general), but they seemed to work pretty well for me.  They also
don't break widgets or weather, so it's a start :-)

Comment 4

[Simon Fraser [no longer active]]

*** Bug 306611 has been marked as a duplicate of this bug. ***

Comment 5

[Simon Fraser [no longer active]]

Fixed on trunk, will land on branch too.

Comment 6

[Simon Fraser [no longer active]]

Changes checked into branch. I didn't use all the rules in comment #3, because I
wanted to just fix the false positives for now. We can tweak incrementally.