306573 - Do not display both "Mark as junk" and "Mark as not junk"

Status: VERIFIED DUPLICATE of bug 273223

(Thunderbird :: Mail Window Front End, enhancement)

Description

[Matjaz]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050830 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050830 Firefox/1.0+

In context menu, under mark there are entries for both "as junk" and "as not
junk". There should be only one entry, depending on message junk status (as it
is true with toolbar icon).

Having both entries seems to confuse some users.

version 1.0+ (20050830)

Reproducible: Always

Steps to Reproduce:

Comment 1

[Mike Cowperthwaite]

There is a reason for this: the message can have a third state, "unclassified."
A better solution might be to disable one of the two Junk options if it doesn't 
apply to the current message(s).

Comment 2

[Adam Guthrie]

I guess this could be duped as bug 273223 if we use the same context menu code.

Comment 3

[Matjaz]

Didn't know messages can be unclassified...

But this leads me to another question: how do we know which messages are
unclassified and which are marked as not junk? If we mark a message as junk, an
icon appear under junk status. There should be an icon for unclassified messages
as well.

There's probably a lot of users (me included) that didn't read the manual and
don't know about unclassified messages. Yes, I know we should read the manual,
but  still, current UI leads us to believe we only have two statuses: junk and
not junk.

Comment 4

[Mike Cowperthwaite]

(In reply to comment #3)
> But this leads me to another question: how do we know which messages are
> unclassified and which are marked as not junk? If we mark a message as junk,
> an icon appear under junk status. There should be an icon for unclassified
> messages as well.

xref bug 192153, bug 182386.
I'm pretty sure I've seen instructions on how to customize this so you *do* get 
a separate icon, altho you have to provide the icon.  There may be skins that do 
this.  Try posting a query on the newsgroups or Mozillazine.

Comment 5

[Matjaz]

I've read comments at 182386 - most people agree with what I've previously said.
Too bad the decision was made contrary to what most people want.

Anyway, this topic has alwady been covered, so there's no use discussing it
again here, especially since we're a little away from the original subject.

Comment 6

[Matjaz]

*** This bug has been marked as a duplicate of 273223 ***