306598 - nsGlobalWindow timeout code should use nsRefPtr<>s

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect, P5)

Description

[Blake Kaplan (:mrbkap) (inactive)]

Currently, nsGlobalWindow manages its list of timeouts using manual refcounting
(calling AddRef() and Release() each time ownership changes). This is less than
ideal because it becomes extremely easy to leak timeouts. We should instead use
nsRefPtr<nsTimeout> to do the hard refcounting for us.

The switch won't be entirely trivial, since nsRefPtr<> requires that Release not
take any arguments and we'll have to determine the right structure to hold the
queue of timeouts (would an nsDeque work? Or is there a better choice?).

Comment 1

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

This was fixed at some point in the past 14 years.