306631 - crash when switching encoding when viewing source

Status: RESOLVED WORKSFORME

(Camino Graveyard :: General, defect, P1)

Description

[Ulrik Sverdrup]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050829 Camino/0.9a2+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050829 Camino/0.9a2+

Camino crashes when switching encoding on a view-source page!

I get consistent results for all kinds of pages.

Reproducible: Always

Steps to Reproduce:
1. Load a web page
2. Choose view source, and switch to that tab
3. Switch character encoding while viewing the source

Actual Results:  
Camino hangs for a seconds, and crashes

Expected Results:  
The content should be reparsed with the new encoding

Trackbacks TB8914254G and TB8914376H

Comment 1

[Samuel Sidler (old account; do not CC)]

Confirming...

Comment 2

[Simon Fraser [no longer active]]

Attachment: Crash log

Comment 3

[Simon Fraser [no longer active]]

Top of stack looks like:

0   <<00000000>> 	0x63657300 0 + 1667592960
1   org.mozilla.navigator    	0x00224334
nsDocShell::SetHistoryEntry(nsCOMPtr<nsISHEntry>*, nsISHEntry*) + 36
2   org.mozilla.navigator    	0x0022137c nsDocShell::InternalLoad(nsIURI*,
nsIURI*, nsISupports*, unsigned, unsigned short const*, char const*,
nsIInputStream*, nsIInputStream*, unsigned, nsISHEntry*, int, nsIDocShell**,
nsIRequest**) + 3172
3   org.mozilla.navigator    	0x00223b98
nsDocShell::LoadHistoryEntry(nsISHEntry*, unsigned) + 1048
4   org.mozilla.navigator    	0x0021a2c8 nsDocShell::Reload(unsigned) + 356

Comment 4

[Simon Fraser [no longer active]]

WFM in current build. Maybe fixed by bug 304639?

Comment 5

[Samuel Sidler (old account; do not CC)]

It's fixed, but it couldn't have been that checkin since it was closed on 8/21
and this bug happened with builds from 8/29 and later.

But it definitely works now. Version 2005090804 (0.9a2+)

Resolving WFM...