306644 - All day events override view restrictions in day and week view

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Gavin Swanson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

When the day and week views are restricted to a given time interval an all day
event will override that interval.

Reproducible: Always

Steps to Reproduce:
1. Restrict the view to 9:00am to 6:00pm
2. Add an all day event

Actual Results:  
The view restriction is overridden and now displays from 12:00am till 6:00pm.
The view restriction returns after the event is deleted

Expected Results:  
All day events are listed in the bar at the top of the view and should not
affect the view restrictions.

Comment 1

[gekacheka]

Attachment: skip all day events when computing limits of day view

(patch -l -p 2 -i file.patch)

With this patch, in day view an all-day event no longer forces the day to start
at 0:00.

Comment 2

[gekacheka]

Attachment: skip all day events when computing limits of day and week view

(patch -l -p 2 -i file.patch)

Fixes both day and week view.

With this patch, in day view an all-day event no longer forces the day to start

at 0:00.

Comment 3

[Joey Minta]

Comment on attachment 195680 [details] [diff] [review]
skip all day events when computing limits of day and week view

For me, all-day items in week-view end up looking weird as a result of this
patch.	(They're very narrow.)	The elementOfReference used to define the width
is no longer a good reference
http://lxr.mozilla.org/mozilla/source/calendar/resources/content/weekView.js#41
4

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 195680 [details] [diff] [review]
skip all day events when computing limits of day and week view

>+      if (!(event.start.isDate && event.end.isDate)) { 

In other places, we just check for .isDate on the startdate. You check is
likely more correct, but I think we should try to be consistent, otherwise
events might disappear or show double.
(Actually, what does it mean if an event has start.isDate set to true, but
end.isDate to false?)

Nit: the indentation is weird.

Comment 5

[gekacheka]

Attachment: skip all day events when computing limits of day and week view (omit end.isDate)

(patch -l -p 2 -i file.patch)

Removed end.isDate from all-day condition.

Was just trying to program defensively.  RFC2445 does not say the value type
has to be matched on start/end dates.  Imported data will come from a variety
of sources.  A date without time is effectively midnight, so an event that
started at 20050913 and ended at 20050913T0800 would last 8 hours.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 195956 [details] [diff] [review]
skip all day events when computing limits of day and week view (omit end.isDate)

r=mvl

Comment 7

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in (with indenting fixed)